feat: native support for Websockets

packages/kit/package.json

@@ -20,6 +20,7 @@
 	"dependencies": {
 		"@types/cookie": "^0.6.0",
 		"cookie": "^0.6.0",
+		"crossws": "^0.3.2",
 		"devalue": "^5.1.0",
 		"esm-env": "^1.0.0",
 		"import-meta-resolve": "^4.1.0",

packages/kit/src/exports/index.js

@@ -102,6 +102,38 @@ export function redirect(status, location) {
 	);
 }
 
+/**
+ * Rejects a websocket upgrade request. When called during request handling, SvelteKit will throw a rejection response.
+ * Make sure you're not catching the thrown rejection, which would prevent SvelteKit from handling it.
+ * @param {400 | 401 | 402 | 403 | 404 | 405 | 406 | 407 | 408 | 409 | 410 | 411 | 412 | 413 | 414 | 415 | 416 | 417 | 418 | 421 | 422 | 423 | 424 | 425 | 426 | 428 | 429 | 431 | 451 | 500 | 501 | 502 | 503 | 504 | 505 | 506 | 507 | 508 | 510 | 511 | ({} & number)} status The [HTTP status code](https://developer.mozilla.org/en-US/docs/Web/HTTP/Status#redirection_messages). Must be in the range 400-599.
+ * @param {string} message The message to send to the client.
+ * @throws {Response} This error instructs SvelteKit to reject the websocket upgrade request.
+ * @throws {Error} If the provided status is invalid.
+ * @return {never}
+ */
+export function reject(status, message) {
+	if ((!BROWSER || DEV) && (isNaN(status) || status < 400 || status > 599)) {
+		throw new Error(`HTTP error status codes must be between 400 and 599 — ${status} is invalid`);
+	}
+
+	throw new Response(message, {
+		status,
+		headers: {
+			'Content-Type': 'text/plain'
+		}
+	});
+}
+
+/**
+ * Accepts a websocket upgrade request. When called during request handling, SvelteKit will accept the websocket upgrade request.
+ * @return {Response} This response instructs SvelteKit to accept the websocket upgrade request.
+ */
+export function accept() {
+	return new Response(null, {
+		status: 200,
+	});
+}
+
 /**
  * Checks whether this is a redirect thrown by {@link redirect}.
  * @param {unknown} e The object to check.

packages/kit/src/exports/public.d.ts

@@ -19,6 +19,7 @@ import {
 } from '../types/private.js';
 import { BuildData, SSRNodeLoader, SSRRoute, ValidatedConfig } from 'types';
 import type { PluginOptions } from '@sveltejs/vite-plugin-svelte';
+import { AdapterInstance, Hooks } from 'crossws';
 
 export { PrerenderOption } from '../types/private.js';
 

packages/kit/src/exports/vite/dev/index.js

@@ -2,6 +2,7 @@ import fs from 'node:fs';
 import path from 'node:path';
 import process from 'node:process';
 import { URL } from 'node:url';
+import crossws from 'crossws/adapters/node';
 import { AsyncLocalStorage } from 'node:async_hooks';
 import colors from 'kleur';
 import sirv from 'sirv';
@@ -421,7 +422,7 @@ export async function dev(vite, vite_config, svelte_config) {
 	const env = loadEnv(vite_config.mode, svelte_config.kit.env.dir, '');
 	const emulator = await svelte_config.kit.adapter?.emulate?.();
 
-	return () => {
+	return async () => {
 		const serve_static_middleware = vite.middlewares.stack.find(
 			(middleware) =>
 				/** @type {function} */ (middleware.handle).name === 'viteServeStaticMiddleware'
@@ -431,6 +432,36 @@ export async function dev(vite, vite_config, svelte_config) {
 		// serving routes with those names. See https://github.com/vitejs/vite/issues/7363
 		remove_static_middlewares(vite.middlewares);
 
+		// we have to import `Server` before calling `set_assets`
+		const { Server } = /** @type {import('types').ServerModule} */ (
+			await vite.ssrLoadModule(`${runtime_base}/server/index.js`, { fixStacktrace: true })
+		);
+
+		const { set_fix_stack_trace } = await vite.ssrLoadModule(`${runtime_base}/shared-server.js`);
+		set_fix_stack_trace(fix_stack_trace);
+
+		const { set_assets } = await vite.ssrLoadModule('__sveltekit/paths');
+		set_assets(assets);
+
+		const server = new Server(manifest);
+
+		// we have to initialize the server before we can call the resolve function to populate the webhook resolver in the websocket handler
+		await server.init({
+			env,
+			read: (file) => createReadableStream(from_fs(file))
+		});
+
+		/** @type {import('crossws/adapters/node').NodeAdapter} */
+		const ws = crossws({
+			resolve: server.resolve()
+		});
+
+		vite.httpServer?.on('upgrade', (req, socket, head) => {
+			if (req.headers['sec-websocket-protocol'] !== 'vite-hmr') {
+				ws.handleUpgrade(req, socket, head);
+			}
+		});
+
 		vite.middlewares.use(async (req, res) => {
 			// Vite's base middleware strips out the base path. Restore it
 			const original_url = req.url;
@@ -474,26 +505,6 @@ export async function dev(vite, vite_config, svelte_config) {
 					return;
 				}
 
-				// we have to import `Server` before calling `set_assets`
-				const { Server } = /** @type {import('types').ServerModule} */ (
-					await vite.ssrLoadModule(`${runtime_base}/server/index.js`, { fixStacktrace: true })
-				);
-
-				const { set_fix_stack_trace } = await vite.ssrLoadModule(
-					`${runtime_base}/shared-server.js`
-				);
-				set_fix_stack_trace(fix_stack_trace);
-
-				const { set_assets } = await vite.ssrLoadModule('__sveltekit/paths');
-				set_assets(assets);
-
-				const server = new Server(manifest);
-
-				await server.init({
-					env,
-					read: (file) => createReadableStream(from_fs(file))
-				});
-
 				const request = await getRequest({
 					base,
 					request: req

packages/kit/src/runtime/server/endpoint.js

@@ -18,6 +18,10 @@ export async function render_endpoint(event, mod, state) {
 		handler = mod.GET;
 	}
 
+	console.log('mod', mod);
+	console.log('method', method);
+	console.log('handler', handler);
+
 	if (!handler) {
 		return method_not_allowed(mod, method);
 	}

packages/kit/src/runtime/server/index.js

@@ -1,4 +1,5 @@
 import { respond } from './respond.js';
+import { resolve } from './resolve.js';
 import { set_private_env, set_public_env, set_safe_public_env } from '../shared-server.js';
 import { options, get_hooks } from '__SERVER__/internal.js';
 import { DEV } from 'esm-env';
@@ -17,15 +18,15 @@ const prerender_env_handler = {
 
 export class Server {
 	/** @type {import('types').SSROptions} */
-	#options;
+	options;
 
 	/** @type {import('@sveltejs/kit').SSRManifest} */
 	#manifest;
 
 	/** @param {import('@sveltejs/kit').SSRManifest} manifest */
 	constructor(manifest) {
 		/** @type {import('types').SSROptions} */
-		this.#options = options;
+		this.options = options;
 		this.#manifest = manifest;
 
 		set_manifest(manifest);
@@ -44,8 +45,8 @@ export class Server {
 
 		// set env, in case it's used in initialisation
 		const prefixes = {
-			public_prefix: this.#options.env_public_prefix,
-			private_prefix: this.#options.env_private_prefix
+			public_prefix: this.options.env_public_prefix,
+			private_prefix: this.options.env_private_prefix
 		};
 
 		const private_env = filter_private_env(env, prefixes);
@@ -63,19 +64,19 @@ export class Server {
 			set_read_implementation(read);
 		}
 
-		if (!this.#options.hooks) {
+		if (!this.options.hooks) {
 			try {
 				const module = await get_hooks();
 
-				this.#options.hooks = {
+				this.options.hooks = {
 					handle: module.handle || (({ event, resolve }) => resolve(event)),
 					handleError: module.handleError || (({ error }) => console.error(error)),
 					handleFetch: module.handleFetch || (({ request, fetch }) => fetch(request)),
 					reroute: module.reroute || (() => {})
 				};
 			} catch (error) {
 				if (DEV) {
-					this.#options.hooks = {
+					this.options.hooks = {
 						handle: () => {
 							throw error;
 						},
@@ -95,7 +96,20 @@ export class Server {
 	 * @param {import('types').RequestOptions} options
 	 */
 	async respond(request, options) {
-		return respond(request, this.#options, this.#manifest, {
+		return respond(request, this.options, this.#manifest, {
+			...options,
+			error: false,
+			depth: 0
+		});
+	}
+
+	/**
+	 * Returns a function that resolves the websocket hooks for a given request
+	 * @param {import('types').RequestOptions} options
+	 * @returns {(info: Request) => import('types').MaybePromise<Partial<import('crossws').Hooks>>}
+	 */
+	resolve(options) {
+		return resolve(this.options, this.#manifest, {
 			...options,
 			error: false,
 			depth: 0

packages/kit/src/runtime/server/resolve.js

@@ -0,0 +1,156 @@
+import { DEV } from 'esm-env';
+import { validate_server_exports } from '../../utils/exports.js';
+import { exec } from '../../utils/routing.js';
+import { decode_pathname, decode_params } from '../../utils/url.js';
+import { base } from '__sveltekit/paths';
+
+/**
+ * @param {import('types').SSROptions} options
+ * @param {import('@sveltejs/kit').SSRManifest} manifest
+ * @param {import('types').SSRState} state
+ * @returns {(info: RequestInit | import('crossws').Peer) => import('types').MaybePromise<Partial<import('crossws').Hooks>>}
+ */
+export function resolve(options, manifest, state) {
+	return async (info) => {
+		/** @type {RequestInit} */
+		let request;
+
+		// These types all need to be straightened out
+		if (info.request) {
+			request = info.request;
+		} else {
+			request = info;
+		}
+
+		/** URL but stripped from the potential `/__data.json` suffix and its search param  */
+		const url = new URL(request.url);
+
+		// reroute could alter the given URL, so we pass a copy
+		let rerouted_path;
+		try {
+			rerouted_path = options.hooks.reroute({ url }) ?? url.pathname;
+		} catch {
+			return {};
+		}
+
+		let decoded;
+		try {
+			decoded = decode_pathname(rerouted_path);
+		} catch (e) {
+			console.error(e);
+			return {};
+		}
+
+		if (base && decoded.startsWith(base)) {
+			decoded = decoded.slice(base.length) || '/';
+		}
+
+		/** @type {import('types').SSRRoute | null} */
+		let route = null;
+
+		/** @type {Record<string, string>} */
+		let params = {};
+
+		try {
+			// TODO this could theoretically break - should probably be inside a try-catch
+			const matchers = await manifest._.matchers();
+
+			for (const candidate of manifest._.routes) {
+				const match = candidate.pattern.exec(decoded);
+
+				if (!match) continue;
+
+				const matched = exec(match, candidate.params, matchers);
+				if (matched) {
+					route = candidate;
+					params = decode_params(matched);
+					break;
+				}
+			}
+		} catch (e) {
+			console.error(e);
+			return {};
+		}
+
+		/** @type {Record<string, string>} */
+		const headers = {};
+
+		try {
+			// determine whether we need to redirect to add/remove a trailing slash
+			if (route && route.endpoint) {
+				// if `paths.base === '/a/b/c`, then the root route is `/a/b/c/`,
+				// regardless of the `trailingSlash` route option
+
+				const node = await route.endpoint();
+
+				if (DEV) {
+					validate_server_exports(node, /** @type {string} */ (route.endpoint_id));
+				}
+
+				return {
+					...node.socket,
+					upgrade: async (req) => {
+						/** @type {import('@sveltejs/kit').RequestEvent} */
+						const event = {
+							// @ts-expect-error `cookies` and `fetch` need to be created after the `event` itself
+							cookies: null,
+							// @ts-expect-error
+							fetch: null,
+							getClientAddress:
+								state.getClientAddress ||
+								(() => {
+									throw new Error(
+										`${__SVELTEKIT_ADAPTER_NAME__} does not specify getClientAddress. Please raise an issue`
+									);
+								}),
+							locals: {},
+							params,
+							platform: state.platform,
+							request: req,
+							route: { id: route?.id ?? null },
+							setHeaders: (new_headers) => {
+								for (const key in new_headers) {
+									const lower = key.toLowerCase();
+									const value = new_headers[key];
+
+									if (lower === 'set-cookie') {
+										throw new Error(
+											'Use `event.cookies.set(name, value, options)` instead of `event.setHeaders` to set cookies'
+										);
+									} else if (lower in headers) {
+										throw new Error(`"${key}" header is already set`);
+									} else {
+										headers[lower] = value;
+
+										if (state.prerendering && lower === 'cache-control') {
+											state.prerendering.cache = /** @type {string} */ (value);
+										}
+									}
+								}
+							},
+							url,
+							isDataRequest: false,
+							isSubRequest: state.depth > 0
+						};
+
+						const response = await options.hooks.handle({
+							event,
+							resolve: async (event) => {
+								if (node.socket && node.socket.upgrade) {
+									return await node.socket.upgrade(event.request);
+								} else {
+									return new Response('Not Implemented', { status: 501 });
+								}
+							}
+						});
+
+						return response ?? new Response('Not Implemented', { status: 501 });
+					}
+				};
+			}
+		} catch (e) {
+			console.error(e);
+			return {};
+		}
+	};
+}