Skip to content

Commit

Permalink
Added support for build key in v3
Browse files Browse the repository at this point in the history
Resolves kubernetes#636

This PR will add support for `build` in docker compose v3.
As docker/cli#481 got merged now
  • Loading branch information
surajnarwade committed Oct 12, 2017
1 parent 903acfd commit 61d8579
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions pkg/loader/compose/v3.go
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,9 @@ func dockerComposeToKomposeMapping(composeObject *types.Config) (kobject.Kompose
// TODO: Build is not yet supported, see:
// https://github.com/docker/cli/blob/master/cli/compose/types/types.go#L9
// We will have to *manually* add this / parse.
// serviceConfig.Build = composeServiceConfig.Build.Context
// serviceConfig.Dockerfile = composeServiceConfig.Build.Dockerfile
serviceConfig.Build = composeServiceConfig.Build.Context
serviceConfig.Dockerfile = composeServiceConfig.Build.Dockerfile
serviceConfig.BuildArgs = composeServiceConfig.Build.Args

// Gather the environment values
// DockerCompose uses map[string]*string while we use []string
Expand Down

0 comments on commit 61d8579

Please sign in to comment.