Add build key support for v3 of Docker Compose

[cdrage]

This will have to be fixed upstream as the code here in docker/cli ignores build at the moment: https://github.com/docker/cli/blob/master/cli/compose/types/types.go#L9

This is a tracking issue as #600 has yet to be merged.

[surajssd]

@cdrage #600 is merged!

[cdrage]

@surajssd Yes, but this issue is for post-# #600 merge. V3 Build support does not work due to: https://github.com/docker/cli/blob/master/cli/compose/types/types.go#L9 (see ignored section), thus we don't map it in Kompose.

[surajnarwade]

@surajssd @cdrage , as build is still unsupported in https://github.com/docker/cli/blob/master/cli/compose/types/types.go#L9 , shall we use it from v1v2.go for v3.go ?
does it make sense ? if yes I am up for this :)

[cdrage]

@surajnarwade
Yes, we are indeed going to be re-using the code from v1v2.go in v3.go but that's the easy part, the problem is parsing v3 correctly so we can actually retrieve the information.

This would have to be fixed upstream unfortunately, or we can find a work-around to retrieve the keys.

[cdrage]

When the time comes, we will move the build conversion code to a separate file (compose.go maybe where the other functions are? So both v1v2.go and v3.go can use it.

If you can find a way to retrieve the build key that'd be great! 👍 💯 👍 (we don't need to figure out the build key conversion, we already figured that part out 😄 )

[surajnarwade]

thanks , @cdrage I will give it a try :)

[cdrage]

I think we should set this as high-priority so we can add build support for Compose V3 as that is the only thing that is missing between v1v2 and v3.. Unfortunately it's due to the key being missing from https://github.com/docker/cli/blob/master/cli/compose/types/types.go#L9 so we can use it to parse Docker Compose.

[cdrage]

PR pushed here: docker/cli#481

[coli]

Looks like it doesn't support just a string for build.

• 'Build' expected a map, got 'string'

[surajnarwade]

@coli , yeah :(
need to fix that in docker/cli

[surajnarwade]

@coli , that problem will resolve after docker/libcompose#498 gets merged and again vendoring for libcompose and docker/cli

[cdrage]

@surajnarwade No idea why you're referencing docker/libcompose. Docker Compose V3 support within Kompose is using docker/cli

Your PR is here: #846 for Version 3 implementation.

@coli are you using Version 2 or Version 3 in your Docker Compose YAML file?

If you're using Version 2, this is a separate issue as Version 3 is yet to be supported.

[surajnarwade]

@cdrage , @coli is getting issue for v3, to solve this, I need to update Docker CLI vendor and then libcompose to solve logrus issues as well as build context issue

[coli]

I'm on v3.

[cdrage]

Okay, so your statement about libcompose was unrelated.. The problem will not be resolved after docker/libcompose#498 is merged in. It will be resolved after #846

[surajnarwade]

@cdrage to merge #846 , I need to update vendor for docker/cli upon which kompose is breaking due to logrus stuff

[tsauvajon]

How do you fix 'Build' expected a map, got 'string' for v3 when running kompose convert ? I'm on a Windows platform.

[rkachowski]

@tsauvajon I've had this same problem, it looks like kompose doesn't respect the optional string parameter. You can work around it by changing the config to a map like so

  build:
    context: ./build_path

[tsauvajon]

@rkachowski oh okay I had not understood the error message thanks a lot!