Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: General error in email verification and email password API #175

Merged
merged 15 commits into from
Jun 23, 2022

Conversation

rishabhpoddar
Copy link
Contributor

@rishabhpoddar rishabhpoddar commented Jun 15, 2022

Summary of change

  • email password
  • email verification

Related issues

Test Plan

Frontend integation tests

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py

Remaining TODOs for this PR

  • All recipes
  • Tests

@rishabhpoddar rishabhpoddar changed the title feat!: General error in all APIs feat!: General error in email verification and email password API Jun 15, 2022
@rishabhpoddar rishabhpoddar requested a review from sattvikc June 15, 2022 08:21
@rishabhpoddar rishabhpoddar marked this pull request as ready for review June 23, 2022 13:04
@rishabhpoddar rishabhpoddar merged commit 116eb09 into next-breaking-change Jun 23, 2022
@rishabhpoddar rishabhpoddar deleted the api-general-error branch June 23, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants