Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to send a general error in all responses from FDI APIs #220

Closed
7 tasks done
rishabhpoddar opened this issue Nov 24, 2021 · 0 comments
Closed
7 tasks done

Comments

@rishabhpoddar
Copy link
Contributor

rishabhpoddar commented Nov 24, 2021

One of the FDI rules is that we should be able to always return a generic error message to the frontend. That's true for some APIs, and not true for others:

  • Third party signinup returns a FIELD_ERROR. It would be better to rename it to GENERAL_ERROR
  • Email password's sign in / sign up frontend UI can handle a GENERAL_ERROR, but the API doesn't have a way to send that..
  • Make sure that all the UI is able to render custom messages sent via GENERAL_ERROR.
  • Check for all APIs (except for session refresh) in the FDI to be able to do that or not.
  • Change email / sms sending errors to throw errors instead of returning general errors
  • In Golang, change onGeneralError function name.
  • New FDI version and FDI spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant