Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(postgrest): deprecate URLQueryRepresentable in favor of PostgrestFilterValue #670

Merged
merged 2 commits into from
Feb 22, 2025

Conversation

grdsdev
Copy link
Collaborator

@grdsdev grdsdev commented Feb 19, 2025

This pull request includes changes to the PostgrestFilterBuilder class and its extensions to replace the use of URLQueryRepresentable with PostgrestFilterValue. This change affects various filter methods to ensure consistency and improve type safety.

Key changes include:

Deprecation Updates:

  • Updated deprecated methods in Sources/PostgREST/Deprecated.swift to use PostgrestFilterValue instead of URLQueryRepresentable for parameters. [1] [2] [3] [4]

Filter Method Updates:

@grdsdev grdsdev changed the title refactor(postgrest): deprecate URLQueryRepresentable in favor of PostgrestFilterValue refactor(postgrest): deprecate URLQueryRepresentable in favor of PostgrestFilterValue Feb 19, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13421489486

Details

  • 68 of 69 (98.55%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 74.937%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Sources/PostgREST/PostgrestFilterValue.swift 41 42 97.62%
Totals Coverage Status
Change from base Build 13410688404: -0.01%
Covered Lines: 5056
Relevant Lines: 6747

💛 - Coveralls

@grdsdev grdsdev requested a review from dshukertjr February 20, 2025 12:23
@dshukertjr
Copy link
Member

Isn't this a breaking change?

@grdsdev
Copy link
Collaborator Author

grdsdev commented Feb 21, 2025

@dshukertjr no breaking change, URLQueryRepresentable is a typealias of the new added PostgresFilterValue, and was marked as deprecated.

@grdsdev grdsdev merged commit 86bc9e5 into main Feb 22, 2025
20 of 21 checks passed
@grdsdev grdsdev deleted the guilherme/refactor-URLQueryRepresentable branch February 22, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants