-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(realtime): add predefined filters instead of regular String
#669
Conversation
String
String
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work here, just a few change requests.
We'd also need some tests for the new filter type.
String
String
a1576f5
to
6bd5fd7
Compare
@grdsdev Let me know what you think of my update, and I'll finalize the tests based on your feedback |
Pull Request Test Coverage Report for Build 13441029480Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're on the right track, just a few more changes.
I hope you'll enjoy the changes :) |
32745e6
to
f074ac2
Compare
Hey! So I'm trying to have 2 filters in my code, one .eq to a row and one change in a specific column (corresponding to that row) |
Hi @AronnK multiple filters aren't supported yet, follow the thread supabase/realtime-js#97 to know more. |
Hey @grdsdev, thanks for the information! |
What kind of change does this PR introduce?
This PR introduces predefined filters for
RealtimeChannelV2
instead of using a regularString
(see my Feature Request and issue)What is the current behavior?
A
String
passed as a parameter by the client (error prone)What is the new behavior?
Use predefined filters – similar in syntax to a regular query.