Gh test

[nilesh05apr]

Implement a github action to check unit tests #33

Fresh PR for the above task.

[sudiptob2]

We need several improvements in this action, Let's work on it step by step. 😊

[sudiptob2]

Thanks 🙏
Now we have to run check.sh script instead of running pytest directly in the workflow. I have implemented the required checks in that script, please take a look.

Also, I could not check the cache hit, could you please double-check and make sure caching is working 😊

[nilesh05apr]

@sudiptob2 i have manually re checked, all jobs are running fine and cache hit also successful. Now i need to work on running the bash script in the workflow.
Please check and review the progress.

[sudiptob2]

we don't need to run pytest, its already inside the check.sh

[sudiptob2]

@nilesh05apr I think if you could use pipenv and install dependencies using Pipfile then you need not to install these dev dependencies manually.
Because these dev dependencies are not mentioned in the requirements.txt, it's a hassle to install them one by one in the ghithub actions manually.
if you use pipenv then you can just do

run: pipenv install --dev --verbose

see this github action for example.

[nilesh05apr]

@sudiptob2 i updated the code but the problem for check.sh remains same.

[sudiptob2]

seems better now, But we still have errors right?
below checks might help.
caching : run the action multiple time and confirm that the cache is working
check.sh: I can see this script is failing, I suppose, I was using python as interpreter may be python3 is needed. Also maybe we need to install the missing stubs

[nilesh05apr]

for the caching part i will re run the jobs as many times as required but for the check.sh file i am unable to find and helpful resource.

[sudiptob2]

In my opinion, these changes are goin to the wrong direction, your previous commit was OK, just it might need to install some stub packages, you can revert these changes and I will try to check it myself and you know If I can fix it.

[nilesh05apr]

the problem is caching is also not working properly i have checked several times, can you please comment?

[sudiptob2]

the problem is caching is also not working properly i have checked several times, can you please comment?

Ok, just keep this PR at the previous commit, I will test and update you if I can find anything. You can always do experiments in a separate branch right.

[nilesh05apr]

sure that i can do, i will create a new branch and try experimenting. Thanks

[sudiptob2]

I have implemented/fixed the workflow, see here

you can update your PR with the this code

[nilesh05apr]

Thanks so much @sudiptob2 for the help. I have implemented the changes and have ensured everything is running smoothly.

[nilesh05apr]

@ can you please review and merge the pull request. Thank you

[sudiptob2]

There are a few small differences from what I implemented here
I might have miss a few thing while reviewing this, I would suggest you copy and paste the entire code from here to your file

[sudiptob2]

add a space before this line

[sudiptob2]

Suggested change

- pull_request

[sudiptob2]

Suggested change

- push

[sudiptob2]

Suggested change

	path: ./.venv
	path: .venv

[nilesh05apr]

@sudiptob2 i have copy-pasted the code XD. please review the changes

[sudiptob2]

seems OK

[nilesh05apr]

Thank you @sudiptob2 i had great experience working on this issue.