Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: github actions to run tests #43

Closed
wants to merge 25 commits into from
Closed

wip: github actions to run tests #43

wants to merge 25 commits into from

Conversation

nilesh05apr
Copy link
Contributor

Implement a github action to check unit tests #33

sudiptob2 and others added 16 commits October 6, 2022 11:26
@sudiptob2
[sudiptob2#41] refactor: flake8 plugins and mypy installed
b1bcaca
@sudiptob2
[sudiptob2#41] refactor: flake8 check configuration initial setup
66ca465
@sudiptob2
[sudiptob2#41] refactor: flake8 errors fixed for __main__.py
a72be96
@sudiptob2
[sudiptob2#41] refactor: some flake8 checks are disabled
3e470f2
@sudiptob2
[sudiptob2#41] refactor: uppercase constants are allowed.
366fad1
@sudiptob2
[sudiptob2#41] refactor: calls without explicit base class allowed
2073d85
@sudiptob2
[sudiptob2#41] refactor: doctrsing in package made optional
6fd28d4
@sudiptob2
[sudiptob2#41] refactor: flake8 error in docstring fixed
2059dfd
@sudiptob2
[sudiptob2#41] refactor: some strings refactored
646169c
@sudiptob2
[sudiptob2#41] refactor: overused code fixed
b805025
@sudiptob2
[sudiptob2#41] refactor: f string usage removed
ba108f3
@sudiptob2
[sudiptob2#41] refactor: flake8 error fixed and config defined
e1d5ddc
@sudiptob2
[sudiptob2#41] feature: code quality check script implemented
0710ae7
@sudiptob2
[sudiptob2#41] test: pytest-cov installed
d65b3fc
@sudiptob2
[sudiptob2#41] refactor: mypy errors fixed
be7182a
@nilesh05apr
wip: github actions to run tests
7a0a7bb
sudiptob2
sudiptob2 reviewed Oct 6, 2022
View reviewed changes
Copy link
Owner

@sudiptob2 sudiptob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort 🙏 but this action is not complete and I can see its not even running properly. Can you please try to improve this, I think its not ready for merge yet.

@nilesh05apr
Copy link
Contributor Author

Yes I am working on it.

@nilesh05apr
Copy link
Contributor Author

@sudiptob2 there is some problem running the test scripts.

  challenge = RequestParser.parse()

E TypeError: parse() missing 1 required positional argument: 'challenge_info'

can you please assist me.
thanks

@nilesh05apr
Copy link
Contributor Author

Hello @sudiptob2 I have fixed the issue by adding appropriate arguments to the parse(). All tests are passing and running on github actions can you please review the PR.
Thanks

@nilesh05apr nilesh05apr marked this pull request as ready for review October 6, 2022 11:43
@sudiptob2
Copy link
Owner

can you please assist me
Great 👍 I had already updated the tests, please update your branch. I will help you to updated the workflow in the subsequent conversations. I have also implemented a check.sh script that I want to run in the ci. you can take a look at that

@sudiptob2
Copy link
Owner

It shows changes in 14 files, now it's difficult to review. Maybe there have gone something wrong while you resynced the main branch. Can you check it out? Also its OK if you make a fresh PR.

@nilesh05apr
Copy link
Contributor Author

yeah i was suggesting same. it got clumsy. i will start a fresh new pr.

@sudiptob2
Copy link
Owner

similar PR at #46

@sudiptob2 sudiptob2 closed this Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudiptob2 sudiptob2 sudiptob2 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilesh05apr @sudiptob2