fix: correct function compound names for IntervalDay and IntervalYear #240 #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rait-io#240 According to the documentation (https://substrait.io/extensions/#function-signature-compound-names) the short types for IntervalDay and IntervalYear are iday and iyear
vbarua
reviewed
Mar 29, 2024
| } | ||
|
|
||
| @Override | ||
| public String visit(final Type.IntervalDay expr) { | ||
| return "day"; | ||
| return "iday"; | ||
| } |
There was a problem hiding this comment.
These now match what is expected based on https://substrait.io/extensions/#function-signature-compound-names
vbarua
changed the title
vbarua
approved these changes
Mar 29, 2024
|
Lint failures are coming from commit which will disappear on merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation the short types for IntervalDay and IntervalYear are iday and iyear
https://substrait.io/extensions/#function-signature-compound-names
#240