Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short type mismatch for intervals between the doc and the implementation #240

Closed
ajegou opened this issue Mar 29, 2024 · 0 comments
Closed

Comments

@ajegou
Copy link
Contributor

ajegou commented Mar 29, 2024

In the documentation short types for interval_day and interval_year are iday iyear:

Screenshot 2024-03-29 at 17 36 15

but the code that does the mapping between type and short type uses day and year instead:

Screenshot 2024-03-29 at 17 36 40

and substrait fails to find the function when loading a logical plan, for example:

java.lang.IllegalArgumentException: Unexpected scalar function with key date_bin:iday_tstz_tstz.
 The namespace ***.yaml is loaded but no scalar function with this key found.
ajegou pushed a commit to ajegou/substrait-java that referenced this issue Mar 29, 2024
…rait-io#240

According to the documentation (https://substrait.io/extensions/#function-signature-compound-names)
the short types for IntervalDay and IntervalYear are iday and iyear
ajegou added a commit to ajegou/substrait-java that referenced this issue Mar 29, 2024
…rait-io#240

According to the documentation (https://substrait.io/extensions/#function-signature-compound-names)
the short types for IntervalDay and IntervalYear are iday and iyear
ajegou added a commit to ajegou/substrait-java that referenced this issue Mar 29, 2024
…rait-io#240

According to the documentation (https://substrait.io/extensions/#function-signature-compound-names)
the short types for IntervalDay and IntervalYear are iday and iyear
@vbarua vbarua closed this as completed Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants