Fix plugin overwrite on_workspace_configuration
#2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's a breaking change for LSP-eslint: https://github.com/sublimelsp/LSP-eslint/blob/fd903029a075497d6c8eeecbe980a6c4748e6ac7/plugin.py#L70-L70 Will you also create a PR that adapts it to use the changed API? (Normally I would prefer a non-breaking change or new API but I think that we can pretty confidently say that nothing else is using this API so it should be fine.) |
|
Yes, I'll create a PR there too. |
LDAP
added a commit
to LDAP/LSP-eslint
that referenced
this pull request
Dec 8, 2022
|
I opened a PR as far as I can see we can publish the LSP-eslint change without breaking anything. The LSP must be released before LSP-jdtls. (I tried to think of a non-breaking solution but could not come up with something better) |
LDAP
added a commit
to LDAP/LSP-eslint
that referenced
this pull request
Dec 9, 2022
LDAP
added a commit
to LDAP/LSP-eslint
that referenced
this pull request
Dec 9, 2022
rchl
pushed a commit
to sublimelsp/LSP-eslint
that referenced
this pull request
Dec 9, 2022
rchl
approved these changes
Dec 9, 2022
|
Released new LSP version with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, plugins can not set the configuration object in
on_workspace_configurationif it isNoneor it has to be replaced completely.This did only work in those cases where
configurationwas a reference to an object that could be altered.See
sublimelsp/LSP-jdtls@85f2392
for an example where the current implementation does not work.
This PR changes
on_workspace_configurationso that it must return the new configuration item. The default implementation now forwards the "pre-resolved" configuration.