Skip to content

Commit

Permalink
Fix plugin overwrite on_workspace_configuration (#2132)
Browse files Browse the repository at this point in the history
  • Loading branch information
LDAP authored Dec 9, 2022
1 parent 9caad05 commit c5c2cf0
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions plugin/core/sessions.py
Original file line number Diff line number Diff line change
Expand Up @@ -866,14 +866,16 @@ def on_settings_changed(self, settings: DottedDict) -> None:
"""
pass

def on_workspace_configuration(self, params: Dict, configuration: Any) -> None:
def on_workspace_configuration(self, params: Dict, configuration: Any) -> Any:
"""
Override to augment configuration returned for the workspace/configuration request.
:param params: A ConfigurationItem for which configuration is requested.
:param configuration: The resolved configuration for given params.
:param configuration: The pre-resolved configuration for given params using the settings object or None.
:returns The resolved configuration for given params.
"""
pass
return configuration

def on_pre_server_command(self, command: Mapping[str, Any], done_callback: Callable[[], None]) -> bool:
"""
Expand Down Expand Up @@ -1644,8 +1646,9 @@ def m_workspace_configuration(self, params: Dict[str, Any], request_id: Any) ->
for requested_item in requested_items:
configuration = self.config.settings.copy(requested_item.get('section') or None)
if self._plugin:
self._plugin.on_workspace_configuration(requested_item, configuration)
items.append(configuration)
items.append(self._plugin.on_workspace_configuration(requested_item, configuration))
else:
items.append(configuration)
self.send_response(Response(request_id, sublime.expand_variables(items, self._template_variables())))

def m_workspace_applyEdit(self, params: Any, request_id: Any) -> None:
Expand Down

0 comments on commit c5c2cf0

Please sign in to comment.