Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elixir to language ids #2100

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Add elixir to language ids #2100

merged 1 commit into from
Oct 26, 2022

Conversation

predragnikolic
Copy link
Member

@@ -91,6 +91,7 @@
"source.yaml.yarn": "yaml", // https://github.com/SublimeText/AFileIcon
"text.advanced_csv": "csv", // https://github.com/SublimeText/AFileIcon
"text.html.basic": "html",
"text.html.elixir": "html", // https://github.com/elixir-editors/elixir-tmbundle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda feels weird to map it to html. For tailwindcss I guess it makes sense but not sure it would make sense if there would exist elixir-specific server. Feels like this is something that should be possible to define per-server maybe.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also source.elixir, I think this change doesn't hurt https://github.com/sublimelsp/LSP-elixir/blob/master/LSP-elixir.sublime-settings

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rchl rchl merged commit 69cff30 into main Oct 26, 2022
@rchl rchl deleted the add-elixir-to-language-ids branch October 26, 2022 21:22
rchl added a commit that referenced this pull request Jan 16, 2023
* main:
  Add elixir to language ids (#2100)
  Add jinja to language ids (#2099)
  Improvements for DocumentLink in hover popup (#2098)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants