Improvements for DocumentLink in hover popup #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Already indicate in the link label if it's a link to a website and will be opened in a browser. - If there are links from multiple sessions, open a quick panel to show the link targets and let the user select, instead of adding several similar looking links into the hover popup.
rchl
reviewed
Oct 25, 2022
| elif len(self._document_links) == 1: | ||
| link = self._document_links[0] | ||
| target = link.get("target") | ||
| label = "Follow Link" if link.get("target", "file:").startswith("file:") else "Open in Browser" |
There was a problem hiding this comment.
I would probably go with Open in Browser if starts with http and otherwise Follow Link because there could be cases where link would use a custom protocol like virtual: or something and it would be a link to a local content.
There was a problem hiding this comment.
Hmm, but I see that _on_navigate handler would then have to be somehow changed to follow that logic...
rchl
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be better for the popup on hover over a DocumentLink, to already indicate that it will be opened in a browser if that is the case. Otherwise it could be a bit surprising for users, because most of the time these are links to a location in another file.
-> Adjust label to "Open in Browser" if the target is not a file uri.
And in case there are multiple sessions at the same time, which all provide DocumentLinks, then combine them into a single link and open a quick panel with the target URIs to choose from when clicked, instead of just putting multiple links into the hover popup.