Add support for triggerKind in code action requests #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
force-pushed
the
feat/trigger_kind_code_action
branch
from
27ab6fb to
8a2fc4d
Compare
predragnikolic
approved these changes
Sep 5, 2022
|
This PR closes #1890 |
jwortmann
reviewed
Sep 5, 2022
rchl
added a commit
to tdaniel22/LSP
that referenced
this pull request
Sep 7, 2022
* main: Add support for triggerKind in code action requests (sublimelsp#2042) Custom context menu in log panel and "Clear log panel" item (sublimelsp#2045) Add icons and isPreferred support for code actions (sublimelsp#2040) Cut 1.18.0
rchl
added a commit
that referenced
this pull request
Sep 11, 2022
* main: Add group argument for LspGotoCommand (#2031) Add context menu entry in log panel for toggling lines limit (#2047) Automatically hide the diagnostics panel on save (#2037) Add support for triggerKind in code action requests (#2042) Custom context menu in log panel and "Clear log panel" item (#2045) Add icons and isPreferred support for code actions (#2040)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set triggerKind for code action requests to indicate whether action was automatic or manual. Typescript server returns different refactorings depending on how the request is made.
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#codeActionContext
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#codeActionTriggerKind
Adding support for triggerKind in typescript in typescript-language-server/typescript-language-server#579 in case someone wants to test.
Resolves #2041
Resolves #1890