Automatically hide the diagnostics panel on save #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we need another option for this (well, unless someone inevitably complains at least) but I would still tie this functionality to the |
tdaniel22
force-pushed
the
close-diagnostics-on-save
branch
from
417f457 to
a0f8d63
Compare
|
Right, forgot that detail. Now if the |
rchl
reviewed
Aug 30, 2022
tdaniel22
force-pushed
the
close-diagnostics-on-save
branch
from
a0f8d63 to
6563d3e
Compare
|
I'm getting pretty far out of my comfort zone here, but I managed to get something working. I'm absolutely not sure this fixes the multiple-servers scenario you mentioned though. Not sure about the change_count checking either, I copied what the |
rchl
reviewed
Aug 30, 2022
tdaniel22
force-pushed
the
close-diagnostics-on-save
branch
from
6563d3e to
e5a36d0
Compare
tdaniel22
force-pushed
the
close-diagnostics-on-save
branch
from
e5a36d0 to
a96e326
Compare
rchl
reviewed
Aug 31, 2022
* main: Add support for triggerKind in code action requests (sublimelsp#2042) Custom context menu in log panel and "Clear log panel" item (sublimelsp#2045) Add icons and isPreferred support for code actions (sublimelsp#2040) Cut 1.18.0
|
👀 will give it a look |
predragnikolic
approved these changes
Sep 7, 2022
rchl
added a commit
that referenced
this pull request
Sep 11, 2022
* main: Add group argument for LspGotoCommand (#2031) Add context menu entry in log panel for toggling lines limit (#2047) Automatically hide the diagnostics panel on save (#2037) Add support for triggerKind in code action requests (#2042) Custom context menu in log panel and "Clear log panel" item (#2045) Add icons and isPreferred support for code actions (#2040)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the "show diagnostics panel on save" feature, and hides the panel if the diagnostics level is higher than the
show_diagnostics_panel_on_savesetting.I took the easy route and and made this the default behaviour, but maybe a better way to do this would be to implement a new option, e.g.
close_diagnostics_panel_on_save.I'm no Python or ST3 plugin expert, so I'm not 100% sure this is the correct way of doing this.
Fixes #1904