Add overridable methods to LspExecuteCommand #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
rwols
reviewed
Aug 20, 2022
rwols
approved these changes
Aug 21, 2022
rchl
added a commit
that referenced
this pull request
Aug 25, 2022
* main: Delay re-calculation of code lenses and inlay hints for currently not visible views Add overridable methods to LspExecuteCommand (#2024)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple addition to make it so that plugins can easily use it with custom response handlers without re-implementing the
runmethod.I've changed the default success handler to not stringify the response as the response can be anything, including a complex object, so it doesn't make sense to assume that it's something that can be presented in the status bar.
Resolves #1902