-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide an optional response handler in LspExecuteCommand #1902
Comments
Sounds like an easy PR. Move Lines 42 to 47 in acfd640
on_result_async(self, response) that the plugin will be able to override.
|
There was this PR that added
Will it suite your usecase? |
Would be kinda weird and hard to follow a code that executes a command in one place but handles the result in a completely different place. So I think this simple change would still be better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
I would like to extends
LspExecuteCommand
in order to send aworkspace/executeCommand
butLspExecuteCommand
simply logs the response. In my case I have to open a file URI that is in the reponse.Describe the solution you'd like
LspExecuteCommand
should provide an optional response handler. When missing simply log the response as the case now. Otherwise delegate the response handling.Describe alternatives you've considered
The current alternative is to copy
LspExecuteCommand
logic.The text was updated successfully, but these errors were encountered: