Discard diagnostics in a few cases

plugin/core/sessions.py

@@ -95,6 +95,12 @@ def get_project_path(self, file_path: str) -> Optional[str]:
         """
         pass
 
+    @abstractmethod
+    def should_present_diagnostics(self, uri: DocumentUri) -> Optional[str]:
+        """
+        Should the diagnostics for this URI be shown in the view? Return a reason why not
+        """
+
     # Mutators
 
     @abstractmethod
@@ -1275,9 +1281,18 @@ def m_workspace_applyEdit(self, params: Any, request_id: Any) -> None:
     def m_textDocument_publishDiagnostics(self, params: Any) -> None:
         """handles the textDocument/publishDiagnostics notification"""
         uri = params["uri"]
+        mgr = self.manager()
+        if not mgr:
+            # debug("ignoring diagnostics for", uri, "due to missing window manager")
+            return
+        reason = mgr.should_present_diagnostics(uri)
+        if isinstance(reason, str):
+            return debug("ignoring unsuitable diagnostics for", uri, "reason:", reason)
         sb = self.get_session_buffer_for_uri_async(uri)
-        if sb:
-            sb.on_diagnostics_async(params["diagnostics"], params.get("version"))
+        if not sb:
+            # debug("ignoring diagnostics for", uri, "due to missing session buffer")
+            return
+        sb.on_diagnostics_async(params["diagnostics"], params.get("version"))
 
     def m_client_registerCapability(self, params: Any, request_id: Any) -> None:
         """handles the client/registerCapability request"""

plugin/core/windows.py

@@ -9,6 +9,7 @@
 from .promise import Promise
 from .protocol import Diagnostic
 from .protocol import DiagnosticSeverity
+from .protocol import DocumentUri
 from .protocol import Error
 from .protocol import Location
 from .sessions import get_plugin
@@ -21,6 +22,7 @@
 from .transports import create_transport
 from .types import ClientConfig
 from .typing import Optional, Any, Dict, Deque, List, Generator, Tuple, Iterable, Sequence, Union
+from .url import parse_uri
 from .views import extract_variables
 from .views import make_link
 from .workspace import ProjectFolders
@@ -32,6 +34,7 @@
 from time import time
 from weakref import ref
 from weakref import WeakSet
+import fnmatch
 import functools
 import json
 import os
@@ -437,6 +440,34 @@ def get_project_path(self, file_path: str) -> Optional[str]:
                     candidate = folder
         return candidate
 
+    def should_present_diagnostics(self, uri: DocumentUri) -> Optional[str]:
+        scheme, path = parse_uri(uri)
+        if scheme != "file":
+            return None
+        if not self._workspace.contains(path):
+            return "not inside window folders"
+        view = self._window.active_view()
+        if not view:
+            return None
+        settings = view.settings()
+        if self._matches_glob(path, settings.get("binary_file_patterns")):
+            return "matches a glob in binary_file_patterns"
+        if self._matches_glob(path, settings.get("file_exclude_patterns")):
+            return "matches a glob in file_exclude_patterns"
+        if self._matches_glob(path, settings.get("folder_exclude_patterns")):
+            return "matches a glob in folder_exclude_patterns"
+        return None
+
+    def _matches_glob(self, path: str, patterns: Any) -> bool:
+        if not isinstance(patterns, list):
+            return False
+        for pattern in patterns:
+            if not isinstance(pattern, str):
+                continue
+            if fnmatch.fnmatch(path, pattern):
+                return True
+        return False
+
     def on_post_exit_async(self, session: Session, exit_code: int, exception: Optional[Exception]) -> None:
         self._sessions.discard(session)
         for listener in self._listeners:

tests/test_session.py

@@ -1,5 +1,6 @@
 from LSP.plugin.core.collections import DottedDict
 from LSP.plugin.core.protocol import Diagnostic
+from LSP.plugin.core.protocol import DocumentUri
 from LSP.plugin.core.protocol import Error
 from LSP.plugin.core.protocol import TextDocumentSyncKindFull
 from LSP.plugin.core.protocol import TextDocumentSyncKindIncremental
@@ -32,6 +33,9 @@ def sessions(self, view: sublime.View, capability: Optional[str] = None) -> Gene
     def get_project_path(self, file_name: str) -> Optional[str]:
         return None
 
+    def should_present_diagnostics(self, uri: DocumentUri) -> Optional[str]:
+        return None
+
     def start_async(self, configuration: ClientConfig, initiating_view: sublime.View) -> None:
         pass