Discard diagnostics in a few cases #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When the file is outside the window folders, ignore diagnostics - When the file matches binary_exclude_patterns, ignore it - When the file matches file_exclude_patterns, ignore it - When the file matches folder_exclude_patterns, ignore it This doesn't take care of the index_exclude_patterns and index_exclude_gitignore settings.
rchl
reviewed
Aug 1, 2021
plugin/core/windows.py
Outdated
Comment on lines
452
to
453
| settings = view.settings() | ||
| if self._matches_glob(path, settings.get("binary_file_patterns")): |
There was a problem hiding this comment.
I have this in my project:
and this are the view settings (the view is within the workspace):
>>> view.settings().get('folder_exclude_patterns')
['.svn', '.git', '.hg', 'CVS', '.mypy_cache', 'node_modules']
It looks like the .nuxt is missing (node_modules comes from global override). So are the view settings not actually updated with project overrides?
There was a problem hiding this comment.
Hmm, I can reproduce this behavior here as well. Seems broken to me.
There was a problem hiding this comment.
|
I'll go ahead and merge this as this has some benefit already. The index_exclude_patterns and project-specific exclude patterns are really more of an ST issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't take care of the index_exclude_patterns and
index_exclude_gitignore settings.
Resolves #1727