Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validAttr): add controlsList to validAttr list #1537

Merged
merged 1 commit into from
Feb 21, 2018

Conversation

marhalpert
Copy link

This PR add controlsList to validAttr list and fixes #1535

@marhalpert marhalpert force-pushed the controlsList-validAttr branch from 8e224eb to 591817c Compare February 20, 2018 22:50
Copy link
Member

@kitten kitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Cheers :)

@kitten kitten merged commit 9a91bde into styled-components:master Feb 21, 2018
@mxstbr
Copy link
Member

mxstbr commented Feb 21, 2018

Thank you so much for helping us improve styled-components! Based on our Community Guidelines every person that has a PR of any kind merged is offered an invitation to the styled-components organization—that is you right now!

Should you accept, you'll get write access to the main repository. (and a fancy styled-components logo on your GitHub profile!) You'll be able to label and close issues, merge pull requests, create new branches, etc. We want you to help us out with those things, so don't be scared to do them! Make sure to read our contribution and community guidelines, which explains all of this in more detail. Of course, if you have any questions just let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

styled.video does not respect controlsList
3 participants