Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump styled-components from 3.1.6 to 3.2.3 #386

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Mar 15, 2018

Bumps styled-components from 3.1.6 to 3.2.3.

Release notes

Sourced from styled-components's releases.

v3.2.3

Fixes

SSR memory leaks? No more!

This release simply frees up some memory by removing cloned StyleSheets when they're not needed anymore.

v3.2.2

Fixes

SSR accumulating non-critical CSS

If you've noticed that v3.2 would cause your server-side rendered app to output all styles it knows of, you weren't alone!

The ServerTag was accidentally cloning itself incorrectly. This meant that the ServerStyleSheet would inherit the same server styles from the “master” StyleSheet.

We now clone the tag correctly and a test is in place to ensure this doesn't happen again, since this bug came up a couple of times in past v2 releases. Thanks to [DeividasK](https://github.com/DeividasK) for reporting this bug!

Fix at-rules nested inside style rules

Have some styles gone missing? In the newer >=3.1 versions that introduced speedy mode (i.e. insertRule support) some rules might not have been injected properly. This came down to insertRule being more strict with what we add. In development an incorrectly formatted CSS rule might not cause much trouble, but in production insertRule complains about it.

Stylis, more specifically stylis-rule-sheet, was generating invalid CSS when at-rules were nested inside style rules. For instance the following CSS would cause trouble:

/* input */
&:hover {
  [**media**](https://github.com/media) (min-width: 768px) { color: papayahwip; }
}

/* incorrect output */
[**media**](https://github.com/media) (min-width: 768px) {
  &:hover { color: papayahwip; }
}}
/* ^ note the extra closing curly brace */

/* v3.2.2 fixed output */
[**media**](https://github.com/media) (min-width: 768px) {
  &:hover { color: papayahwip; }
}

Fix imprecise IS_BROWSER detection

Before v3.2.2 we would check whether styled-components is running inside the browser using: typeof window !== 'undefined'. This proofed insufficient in a couple of special cases for some people, so we have now added 'HTMLElement' in window to this check.

Thanks to [danieldunderfelt](https://github.com/danieldunderfelt) for contributing this fix!

v3.2.1

Fixes

... (truncated)

Changelog

Sourced from styled-components's changelog.

Changelog

All notable changes to this project will be documented in this file. If a contribution does not have a mention next to it, [geelen](https://github.com/geelen) or [mxstbr](https://github.com/mxstbr) did it.

The format is based on Keep a Changelog and this project adheres to Semantic Versioning.

Unreleased

  • Fix SSR memory leak where StyleSheet clones are never freed (see #1612)

[v3.2.2] - 2018-03-13

  • Fix ServerTag.clone() not properly cloning its names and markers (see #1605)

  • Fix nested media at-rules by upgrading to stylis@^3.5.0 and stylis-rule-sheet@^0.0.10 (see #1595)

  • Fix the IS_BROWSER check to work more reliably in projects where window may be shimmed, by [danieldunderfelt](https://github.com/danieldunderfelt) (see #1599)

[v3.2.1] - 2018-03-07

  • Fix [**import**](https://github.com/import) rules not being enforced to appear at the beginning of stylesheets (see #1577)

  • Fix StyleTags toElement outputting inline CSS which would cause URL encoding (see #1580)

[v3.2.0] - 2018-03-05

  • Remove type="text/css"-attribute from style tag to remove warnings from w3c validator (see #1551)

  • Add foreignObject svg element (see #1544)

  • Add controlsList to validAttr list (see #1537)

  • Enable stylis' semicolon autocompletion which was accidentally disabled for a lot of prior releases (see #1532)

  • Fix insertRule injection (speedy mode in production) of nested media queries by upgrading stylis-rule-sheet (see #1529 and #1528)

  • Add StyleSheet.remove API method to be able to delete rules related to a component (see #1514)

  • Replace murmurhash implementation and avoid destructuring tag function arguments (see #1516)

  • Rewrite and refactor StyleSheet and ServerStyleSheet (no breaking change, see #1501)

  • Add warning if there are several instances of styled-components initialized on the page (see #1412)

  • Add target prop to StyleSheetManager component to enable specifying where style tags should render (see #1491)

Commits
  • 78e4975 v3.2.3
  • 6b5143d Update CHANGELOG for v3.2.3
  • 7d3ef92 Merge pull request #1612 from styled-components/fix/ssr-mem-usage
  • c2f1fa7 Clean up implementation of completing ServerStyleSheets
  • d4e32d1 Add CHANGELOG entry
  • 04bcd91 Clean up after clone and remove it from master StyleSheet after SSR
  • f82b191 Merge pull request #1609 from styled-components/release-v3.2.2
  • edbc06e v3.2.2
  • 081abdf Update CHANGELOG for 3.2.2
  • fa872e5 Merge pull request #1599 from danieldunderfelt/better-browser-check
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If you'd like to skip this version, you can just close this PR. If you have any feedback just mention @dependabot in the comments below.


⚠️ Dependabot is rebasing this PR ⚠️

Sit tight and this PR will be updated for you in a minute. If you make any changes yourself then they'll take precedence over the rebase (which will be abandoned).

@codecov
Copy link

codecov bot commented Mar 15, 2018

Codecov Report

Merging #386 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #386   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files          26       26           
  Lines         178      178           
  Branches       15       15           
=======================================
  Hits          177      177           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 436da67...8ee9675. Read the comment docs.

@phyrog phyrog merged commit b1802f9 into master Mar 19, 2018
@phyrog phyrog deleted the dependabot/npm_and_yarn/styled-components-3.2.3 branch March 19, 2018 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants