Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Support workflow_runs for pull_request from forks #55

Merged
merged 2 commits into from
Feb 13, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jan 28, 2021

I have a workflow that requires canceling previous runs for PRs opened from forks. The existing code does not work due to GITHUB_TOKEN limitations, but this should work.

You might want to take this PR for a spin before merge to make sure I did not break any existing functionality.

Might be related: #7, #8, #47, #54 (comment)

README.md Outdated Show resolved Hide resolved
Copy link
Owner

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@styfle styfle merged commit ae895f3 into styfle:main Feb 13, 2021
@pllim pllim deleted the support-pr-workflow-run branch February 15, 2021 21:30
@pllim
Copy link
Contributor Author

pllim commented Feb 15, 2021

Thanks for the merge but I don't understand why the doc is changed to refer to 0.7.0, when I see your latest release is 0.8.0.

@styfle
Copy link
Owner

styfle commented Feb 15, 2021

Because I don't do version updates in PRs and it was not relevant to the PR.

The version is changed in a commit to main here 3d86a7c

@pllim
Copy link
Contributor Author

pllim commented Feb 15, 2021

Okay, thanks for the clarification! I am not familiar with the dev workflow here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants