Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2711: Improve workflow cancellation support in CI #2890

Closed
wants to merge 2 commits into from

Conversation

BenHenning
Copy link
Member

Fix #2711.

Per https://github.com/styfle/cancel-workflow-action#advanced-pull-requests-from-forks functionality was recently added (styfle/cancel-workflow-action#55) to:

  1. Allow cancellation based on workflows starting (regardless of where they start)
  2. Remove the need for the access token, allowing proper fork support (I actually thought this wasn't an issue, but maybe we didn't realize it before)

Both should substantially reduce actions time since subsequent commits should properly cancel everything previous run, both for forks & non-forks. I'm expecting this to fix #2711 but I will need to verify in this PR.

BenHenning and others added 2 commits March 11, 2021 10:06
Add support for forks & multiple workflows in canceller.
@BenHenning BenHenning changed the title [RunAllTests] Fix #2711: Improve workflow cancellation support in CI Fix #2711: Improve workflow cancellation support in CI Mar 11, 2021
@BenHenning
Copy link
Member Author

Hmm it seems like the canceller is not running (all cancelled workflows in the last 2 commits were manual). Will need to dig into why.

PR is probably going to be put on hold for a few days (until I get a brief moment to be able to get back to it).

@anandwana001 anandwana001 added the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label May 7, 2021
@oppiabot
Copy link

oppiabot bot commented Aug 14, 2021

Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 3 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Aug 14, 2021
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Aug 17, 2021
@BenHenning BenHenning closed this Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow canceller doesn't seem to work for dynamic jobs
2 participants