-
Notifications
You must be signed in to change notification settings - Fork 3
Github Workflow
Lindsey Tulloch edited this page Apr 24, 2019
·
1 revision
Beware of rebase and reset. After performing either of these commands a git push --force-with-lease
will be required to update your remote branch and of course, force push can be very dangerous. . .https://stackoverflow.com/questions/33247309/why-is-it-dangerous-to-do-a-force-push-against-a-remote-repository
- Fork the repo
- Clone your fork to a local directory
git clone git@github.com:<your-user-name>/chloroplasts
- Set the upstream to onyiny-ang/chloroplasts
git remote add upstream https://github.com/stroma-lamellae/chloroplasts
orgit@github.com:stroma-lamellae/chloroplasts.git
- hack hack hack hack
- Before making a pull request for a feature, bug fix, or other addition to the code base, rebase your code on top of the upstream master branch:
git fetch upstream
git rebase -i upstream/master
After this step there may be merge conflicts to resolve
- Once you have rebased your changes onto the upstream master branch, open a pull request against upstream/master (onyiny-ang/chloroplasts) with a brief description about your contribution.
- If you see an open pull request, take a few minutes to look through it and point out any errors (grammatical errors in the comments, logic errors in the code, other errors in the code).
- When someone has reviewed your PR, respond to and correct any issues and repeat from point #7.
- When your PR has received a LGTM (Looks Good To Me), squash any minor changes into a single commit:
git rebase -i HEAD~<# of commits from opening pull request to LGTM>
This will allow you to interactively squash and/or drop any changes. Squashing allows you to combine several smaller commits into a larger more significant one. This step isn't strictly necessary but keeps our repo more concise and easier to navigate. - Congratulations your PR is merged into the master repo!