Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Override common dimensions with signalfx_vary_key_by (#780)" #814

Closed
wants to merge 2 commits into from

Conversation

eriwo-stripe
Copy link
Contributor

@eriwo-stripe eriwo-stripe commented Jan 25, 2021

Summary

PR with Stripe patch for the V14 release of Veneur. This pull request only adds the Stripe patch, everything else in the release is already in master.

r? @rma-stripe
cc @stripe/observability

Rollout/monitoring/revert plan

Deployment Plan:

  1. Deploy to QA from feature branch
  2. Bake in QA for a day or two
  3. Merge to master
  4. Deploy to QA from master branch
  5. Bake maybe?
  6. Deploy to Prod
  7. Profit???

Rollback plan:
Will rollback to the current version if anything goes wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants