Override common dimensions with signalfx_vary_key_by #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aditya-stripe || @ChimeraCoder |
ChimeraCoder
approved these changes
Apr 15, 2020
ChimeraCoder
changed the title
👀 Heads Up
|
aditya-stripe
pushed a commit
that referenced
this pull request
Sep 22, 2020
This reverts commit 532b017.
aditya-stripe
pushed a commit
that referenced
this pull request
Dec 18, 2020
This reverts commit 532b017.
aditya-stripe
pushed a commit
that referenced
this pull request
Dec 21, 2020
This reverts commit 532b017.
eriwo-stripe
pushed a commit
that referenced
this pull request
Jan 25, 2021
This reverts commit 532b017.
rma-stripe
pushed a commit
that referenced
this pull request
Feb 1, 2021
This reverts commit 532b017.
rma-stripe
pushed a commit
that referenced
this pull request
Feb 5, 2021
This reverts commit 532b017.
eriwo-stripe
pushed a commit
that referenced
this pull request
Mar 1, 2021
This reverts commit 532b017.
eriwo-stripe
pushed a commit
that referenced
this pull request
Mar 16, 2021
This reverts commit 532b017.
eriwo-stripe
pushed a commit
that referenced
this pull request
Mar 18, 2021
This reverts commit 532b017.
eriwo-stripe
pushed a commit
that referenced
this pull request
Mar 19, 2021
This reverts commit 532b017.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where
signalfx_vary_key_bydoes not vary key based on common dimensions (tags).Motivation
Fixes bug introduced in #776
Test plan
Tested in production + wrote automated test
Rollout/monitoring/revert plan
r? @annab-stripe || @aditya-stripe
cc @stripe/observability