Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for 34 clarification #562

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Update README for 34 clarification #562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Updating to a newer version of the SDK? See our [release notes](https://github.c
### Android

- Android 5.0 (API level 21) and above
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated: once we release a version that uses Terminal Android SDK 3.X or later, this should be bumped to Android 8.0 (API level 26)

* Note that attempting to override minSdkVersion to decrease the minimum supported API level will not work due to internal runtime API level validation. Furthermore, Stripe is updating the Terminal Android SDK to support Google’s recently released Android 14 (SDK 34). Please continue to target SDK 33 in the meantime as there are known issues with mPOS devices and TTP when targeting SDK 34. Please track the following [ticket](https://github.com/stripe/stripe-terminal-android/issues/387) for updates on progress.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Should the "Stripe is updating the Terminal Android..." sentence and everything after it be a note after the targetSdkVersion = 31 line?

- compileSdkVersion = 33
- targetSdkVersion = 31

Expand Down