Update README for 34 clarification #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazli-stripe
requested review from
billfinn-stripe,
bric-stripe and
chr-stripe
as code owners
chr-stripe
approved these changes
Oct 24, 2023
| @@ -33,6 +33,7 @@ Updating to a newer version of the SDK? See our [release notes](https://github.c | |||
| ### Android | |||
|
|
|||
| - Android 5.0 (API level 21) and above | |||
There was a problem hiding this comment.
Unrelated: once we release a version that uses Terminal Android SDK 3.X or later, this should be bumped to Android 8.0 (API level 26)
| @@ -33,6 +33,7 @@ Updating to a newer version of the SDK? See our [release notes](https://github.c | |||
| ### Android | |||
|
|
|||
| - Android 5.0 (API level 21) and above | |||
| * Note that attempting to override minSdkVersion to decrease the minimum supported API level will not work due to internal runtime API level validation. Furthermore, Stripe is updating the Terminal Android SDK to support Google’s recently released Android 14 (SDK 34). Please continue to target SDK 33 in the meantime as there are known issues with mPOS devices and TTP when targeting SDK 34. Please track the following [ticket](https://github.com/stripe/stripe-terminal-android/issues/387) for updates on progress. | |||
There was a problem hiding this comment.
nit: Should the "Stripe is updating the Terminal Android..." sentence and everything after it be a note after the targetSdkVersion = 31 line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Notes issues with targetSdk 34
Motivation
34 issue
Testing
Documentation
Select one: