Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding capture_payment after process #52

Merged
merged 6 commits into from
Mar 11, 2022

Conversation

jdivock-stripe
Copy link
Contributor

@jdivock-stripe jdivock-stripe commented Jan 28, 2022

Blocked while I sort out and land #51

payments now captured at end of flow

fixes #133 and #30

Screen Shot 2022-03-11 at 12 58 49 PM

@jdivock-stripe jdivock-stripe force-pushed the jdivock/example-app-capture branch from 77ba871 to b20b63a Compare March 11, 2022 19:44
@jdivock-stripe jdivock-stripe changed the title [wip] Adding capture_payment after process Adding capture_payment after process Mar 11, 2022
@jdivock-stripe jdivock-stripe force-pushed the jdivock/example-app-capture branch from c176a12 to 6bef83e Compare March 11, 2022 20:56
@jdivock-stripe jdivock-stripe force-pushed the jdivock/example-app-capture branch from 6bef83e to 2539ac5 Compare March 11, 2022 20:57
@@ -1,9 +1,10 @@
{
"compilerOptions": {
"esModuleInterop": true,
"noEmit": true,
Copy link
Contributor Author

@jdivock-stripe jdivock-stripe Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need this to prevent generating *.js files when I was just trying to typecheck

Copy link
Contributor

@dhenry-stripe dhenry-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jdivock-stripe jdivock-stripe merged commit 7ae78d2 into main Mar 11, 2022
arekkubaczkowski pushed a commit to arekkubaczkowski/stripe-terminal-react-native that referenced this pull request Jun 29, 2022
* adding capture action

* fix alias

* tsc

* fixing noemit

* or not

* update tests
@nazli-stripe nazli-stripe deleted the jdivock/example-app-capture branch September 6, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typechecking from the cmd line shouldn't emit code
2 participants