-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use .env for server address in example app #51
Conversation
fae1248
to
54a7e5d
Compare
eeda044
to
e888fa2
Compare
.circleci/config.yml
Outdated
@@ -29,6 +29,13 @@ commands: | |||
background: true | |||
command: xcrun simctl boot "11" || true | |||
|
|||
start_server: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the steps to start the local sever even though it's not in use (yet)
@@ -211,9 +224,6 @@ jobs: | |||
executor: macos_custom | |||
|
|||
steps: | |||
- attach_workspace: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a duplicate step as setting up the executor attaches the workspaces and costs another minute or so
64db76e
to
eb447fb
Compare
b9bcbda
to
88cb90a
Compare
android emu specific url
88cb90a
to
9365ea5
Compare
android emu specific url
What it says on the tin…
API_URL
from env variable and wil also look forAPI_URL_ANDROID
due to it's differing emulator localhost mappingConfigure Detox
to cache Taps and Homebrew cache shaving ~8m from build times!Fixes:
#50
Chips away at #43
Before:
![Screen Shot 2022-02-01 at 10 47 52 AM](https://user-images.githubusercontent.com/30239207/152024013-36877458-dfca-4986-82fc-3aaaf21c9b1d.png)
After:
![Screen Shot 2022-02-01 at 10 47 25 AM](https://user-images.githubusercontent.com/30239207/152023964-31956a3e-0330-445d-ae69-7a32e0cc52bf.png)
Android is roughly as happy (or sad) as it was before:
iOS is the same