Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use .env for server address in example app #51

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

jdivock-stripe
Copy link
Contributor

@jdivock-stripe jdivock-stripe commented Jan 28, 2022

What it says on the tin… 

  • Updates RN and server to pull API_URL from env variable and wil also look for API_URL_ANDROID due to it's differing emulator localhost mapping
  • Moved api key and url env variables into CI project settings
  • Got homebrew step from Configure Detox to cache Taps and Homebrew cache shaving ~8m from build times!
  • bumped CI container size to medium+ in an effort to improve builds times

Fixes:
#50

Chips away at #43

Before:
Screen Shot 2022-02-01 at 10 47 52 AM

After:
Screen Shot 2022-02-01 at 10 47 25 AM

Android is roughly as happy (or sad) as it was before:

FAIL  e2e/app.e2e.js (421.002 s)
  Payments
    ✓ Connect and disconnect (17674 ms)
    ✕ Install required update and connect (206962 ms)
    ✓ Change discovery method to bluetooth proximity (9754 ms)
    ✓ Change discovery method to Internet (9820 ms)
    ✓ Collect card payment (33334 ms)
    ✕ Store card via readReusableCard (40610 ms)
    ✕ Store card via SetupIntent (40367 ms)
    ✓ In-Person Refund failed due to unsupported country (26945 ms)
    ○ skipped Required update impossible due to low battery

iOS is the same

FAIL  e2e/app.e2e.js (275.68 s)
  Payments
    ✓ Connect and disconnect (15753 ms)
    ✓ Install required update and connect (29102 ms)
    ✓ Change discovery method to bluetooth proximity (10929 ms)
    ✓ Change discovery method to Internet (10980 ms)
    ✓ Collect card payment (37770 ms)
    ✕ Store card via readReusableCard (38377 ms)
    ✕ Store card via SetupIntent (35426 ms)
    ✕ In-Person Refund failed due to unsupported country (49366 ms)
    ○ skipped Required update impossible due to low batter

@jdivock-stripe jdivock-stripe force-pushed the jdivock/env-backend branch 3 times, most recently from fae1248 to 54a7e5d Compare January 31, 2022 16:04
@jdivock-stripe jdivock-stripe mentioned this pull request Jan 31, 2022
3 tasks
@jdivock-stripe jdivock-stripe force-pushed the jdivock/env-backend branch 3 times, most recently from eeda044 to e888fa2 Compare January 31, 2022 16:47
@@ -29,6 +29,13 @@ commands:
background: true
command: xcrun simctl boot "11" || true

start_server:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the steps to start the local sever even though it's not in use (yet)

@@ -211,9 +224,6 @@ jobs:
executor: macos_custom

steps:
- attach_workspace:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a duplicate step as setting up the executor attaches the workspaces and costs another minute or so

@jdivock-stripe jdivock-stripe force-pushed the jdivock/env-backend branch 3 times, most recently from 64db76e to eb447fb Compare February 1, 2022 17:58
@jdivock-stripe jdivock-stripe changed the title [wip] use .env for server address in example app use .env for server address in example app Feb 1, 2022
@jdivock-stripe jdivock-stripe merged commit 0f161e6 into main Feb 1, 2022
arekkubaczkowski pushed a commit to arekkubaczkowski/stripe-terminal-react-native that referenced this pull request Jun 29, 2022
@nazli-stripe nazli-stripe deleted the jdivock/env-backend branch September 6, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants