Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip actions] resolve with an error if merchantDisplayName isn't provided #1015

Merged
merged 1 commit into from
Jun 27, 2022
Merged

[skip actions] resolve with an error if merchantDisplayName isn't provided #1015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions android/src/main/java/com/reactnativestripesdk/PaymentSheetFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ class PaymentSheetFragment(
override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
super.onViewCreated(view, savedInstanceState)
val merchantDisplayName = arguments?.getString("merchantDisplayName").orEmpty()
if (merchantDisplayName.isEmpty()) {
initPromise.resolve(createError(ErrorType.Failed.toString(), "merchantDisplayName cannot be empty or null."))
return
}
val customerId = arguments?.getString("customerId").orEmpty()
val customerEphemeralKeySecret = arguments?.getString("customerEphemeralKeySecret").orEmpty()
val countryCode = arguments?.getString("merchantCountryCode").orEmpty()
Expand Down
3 changes: 2 additions & 1 deletion src/types/PaymentSheet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ import type { BillingDetails } from './Common';
export type SetupParams = ClientSecretParams &
GooglePayParams &
ApplePayParams & {
/** Your customer-facing business name. On Android, this is required and cannot be an empty string. */
merchantDisplayName: string;
customerId?: string;
customerEphemeralKeySecret?: string;
customFlow?: boolean;
merchantDisplayName?: string;
style?: 'alwaysLight' | 'alwaysDark' | 'automatic';
returnURL?: string;
defaultBillingDetails?: BillingDetails;
Expand Down