Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip actions] resolve with an error if merchantDisplayName isn't provided #1015

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

charliecruzan-stripe
Copy link
Collaborator

Summary

stripe-android will crash if you pass an empty string to the PaymentSheet.Configuration and then attempt to present the payment sheet, so let's catch that and resolve during the initialization step with an error.

Motivation

closes #980

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@charliecruzan-stripe charliecruzan-stripe removed the request for review from acomley-stripe June 23, 2022 21:37
@charliecruzan-stripe charliecruzan-stripe merged commit 814d8b4 into master Jun 27, 2022
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan-merchantDisplayName branch June 27, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PaymentSheet Crashing on Android since v0.11.0+
1 participant