Fix quotes in version.py
#527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project recently switched over to Black for code formatting in #521. Black expects double-quoted strings throughout the project. We double-quoted this file when that patch was merged, but our release script was still incorrectly producing single quoted strings. I'm just about to patch the release script, but putting this fix in here so that we can fix `master`.
ob-stripe
approved these changes
Jan 25, 2019
|
Thanks @ob-stripe! |
|
I actually already fixed the release script, but not before running it once pre-fix, which resulted in the single-quoted string being committed. Sorry! |
Oh dang, no worries! I think what might've happened here is that you got the string matcher, but not the string replacer. Unlike many other languages, Python's scripts in this area actually check that the value is present before doing anything with it. Either that, or there was some other open PR that was never merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project recently switched over to Black for code formatting in #521.
Black expects double-quoted strings throughout the project. We
double-quoted this file when that patch was merged, but our release
script was still incorrectly producing single quoted strings.
I'm just about to patch the release script, but putting this fix in here
so that we can fix
master.cc @ob-stripe