Use Black for formatting code #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
commented
Jan 15, 2019
ob-stripe
commented
Jan 15, 2019
|
Wow, cool. I didn't go through the whole diff, but scanned about half of it, and all the formatting changes that Black makes seem pretty sane to me. I love formatters. +1 from my perspective. |
ob-stripe
changed the title
|
Pulling this in! |
brandur-stripe
pushed a commit
that referenced
this pull request
Jan 25, 2019
The project recently switched over to Black for code formatting in #521. Black expects double-quoted strings throughout the project. We double-quoted this file when that patch was merged, but our release script was still incorrectly producing single quoted strings. I'm just about to patch the release script, but putting this fix in here so that we can fix `master`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
Black is a code formatter that is quickly gaining traction in the Python community. (Basically
go fmtfor Python.)This PR introduces support for automatically formatting stripe-python's code using black. It adds two new make targets:
fmtis used to automatically format codefmtcheckis used to check that the code is formatted as black expects. This is used in CI, to ensure that code is compliant before merging.Tagged as WIP to get your opinion, but the PR is mostly ready -- the only thing's missing is updating
README.mdwith instructions.