Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update surface to generic paved if footway and cycleway parts are different but paved #4615

Merged
merged 9 commits into from
Dec 3, 2022

Conversation

mnalis
Copy link
Member

@mnalis mnalis commented Nov 6, 2022

This improves #4526 (originally closed by PR #4548):

  • in situation when cycleway and footway are differently paved it will also update surface = paved (previously, it would just always delete surface tag in such case).
  • actually removes smoothness when surface changes (we did test for it, but never actually did it)
  • some more fixes for compilation error for tests that were present in vanilla v49.0 (introduced when different branches were merged)

(This is recommended way to tag different but paved surfaces, see second block in Ref= S5 on https://wiki.openstreetmap.org/wiki/Bicycle#Miscellaneous)


Compiles OK and manually tested that it works fine. It also includes automated test that pass too.

@mnalis mnalis marked this pull request as draft November 6, 2022 21:21
@mnalis mnalis marked this pull request as ready for review November 7, 2022 00:10
@mnalis mnalis requested a review from westnordost November 7, 2022 20:36
@westnordost
Copy link
Member

westnordost commented Nov 7, 2022

Hey @mnalis, no need to request a review from me, I check the pull requests regularly. Marking as ready for review is enough. There are other regular contributors which may review the code as well.
If you request a review specifically from me, you make it look like only I would be able to review this code.

@mnalis
Copy link
Member Author

mnalis commented Nov 7, 2022

Oh sorry, you're the only one the github shows by default, so it seemed inviting button to press 😃
I now see I can press the cog icon to request others too. Everyone is welcome to review of course, but if clicking that button is not required for processing of PR to proceed, than I won't be clicking it in the future. ❤️

(That request-review functionality is then probably less useful in opensource projects, and more useful in corporate environment with strict hierarchy when someone in power is selecting who should do what, I guess? At least I as lowly contributor would feel uncomfortable requesting by name someone more experienced to do the work, unless they previously explicitly expressed interest in that PR)

Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I notice that I refactored the SurfaceAnswer.applyTo function to also remove smoothness if the surface was changed. Hence, part of this PR is obsolete/wrong.

However, I kept you waiting long enough and to save on further back and forth, I will make the changes myself before merging.

@westnordost westnordost merged commit a4b353e into streetcomplete:master Dec 3, 2022
@smichel17
Copy link
Member

smichel17 commented Dec 15, 2022

@mnalis On review requests: I've found them useful in $dayjob not because of hierarchy but more like a shorthand for "I know you worked on this feature in the past, or have some stake in maintaining it, can you check if this is an ok change?" I think a similar thing applies here; someone might want to request my review when touching the recent answers code, for example.

@mnalis mnalis deleted the update-same-surface2 branch December 18, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants