-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update surface to generic paved if footway and cycleway parts are different but paved #4615
Update surface to generic paved if footway and cycleway parts are different but paved #4615
Conversation
(and not if only added detailed cycleway/footway surface information that was previously missing)
Hey @mnalis, no need to request a review from me, I check the pull requests regularly. Marking as ready for review is enough. There are other regular contributors which may review the code as well. |
Oh sorry, you're the only one the github shows by default, so it seemed inviting button to press 😃 (That request-review functionality is then probably less useful in opensource projects, and more useful in corporate environment with strict hierarchy when someone in power is selecting who should do what, I guess? At least I as lowly contributor would feel uncomfortable requesting by name someone more experienced to do the work, unless they previously explicitly expressed interest in that PR) |
app/src/main/java/de/westnordost/streetcomplete/quests/surface/AddCyclewayPartSurface.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I notice that I refactored the SurfaceAnswer.applyTo
function to also remove smoothness
if the surface was changed. Hence, part of this PR is obsolete/wrong.
However, I kept you waiting long enough and to save on further back and forth, I will make the changes myself before merging.
@mnalis On review requests: I've found them useful in $dayjob not because of hierarchy but more like a shorthand for "I know you worked on this feature in the past, or have some stake in maintaining it, can you check if this is an ok change?" I think a similar thing applies here; someone might want to request my review when touching the recent answers code, for example. |
This improves #4526 (originally closed by PR #4548):
surface = paved
(previously, it would just always deletesurface
tag in such case).smoothness
whensurface
changes (we did test for it, but never actually did it)v49.0
(introduced when different branches were merged)(This is recommended way to tag different but
paved
surfaces, see second block inRef
=S5
on https://wiki.openstreetmap.org/wiki/Bicycle#Miscellaneous)Compiles OK and manually tested that it works fine. It also includes automated test that pass too.