-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't ignore contradictory *:surface=*
and surface=*
tags
#4526
Comments
Make sense to me. If someone wants to give it a try, leave a comment stating so. |
One thing I forgot about is that options 2 and 3 of course could also be used to add missing |
Nah, if there are two explicit surface information, I would keep them both. Explicit is always better than implicit IMHO. For example that could be the only part of the way which has the same surface and in the next part they differ again. With just one tag I would second guess if the information is complete for this part. But the surface tag feels kinda superficial, if both parts of that way are already tagged individually. |
Agreed, but if I understood @Discostu36 correctly (hopefully I did, as i did the PRs 😄), it would keep both of them, and then add
and not just:
|
@mnalis You understood my intent correctly. It is a bit redundant, but I think it is the best solution. |
Use case
When SC asks for
footway:surface=*
andcycleway:surface=*
on a segregatedhighway=path
, it does not changesurface=*
, even when it is contradictory.See for example this path.
Proposed Solution
Three possibilities (in ascending effort):
surface=*
tagfootway:surface
andcycleway:surface
, but only if both are the samesurface=*
tag iffootway:surface
andcycleway:surface
are not the same, but both are paved or unpaved (for examplefootway:surface=paving_stones
andcycleway:surface=asphalt
→surface=paved
). If one way is paved and the other one unpaved, it should add them via semicolon (e.g.surface=asphalt;dirt
).The text was updated successfully, but these errors were encountered: