Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix workspace warnings #1194

Closed

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented Oct 8, 2024

fix #1192

Copy link
Contributor

github-actions bot commented Oct 8, 2024

🐰 Bencher Report

Branch1194/merge
Testbedsv1

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
client-submit-serialize📈 view plot
⚠️ NO THRESHOLD
6,779.20
client-submit-serialize-deserialize📈 view plot
⚠️ NO THRESHOLD
7,846.70
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
⚠️ NO THRESHOLD
8,330.60
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
⚠️ NO THRESHOLD
910.57
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
⚠️ NO THRESHOLD
713.22
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
⚠️ NO THRESHOLD
248.39
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
⚠️ NO THRESHOLD
158.95
client-sv1-get-submit📈 view plot
⚠️ NO THRESHOLD
6,559.50
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
⚠️ NO THRESHOLD
275.56
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
⚠️ NO THRESHOLD
781.29
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
⚠️ NO THRESHOLD
660.35
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
⚠️ NO THRESHOLD
204.54
🐰 View full continuous benchmarking report in Bencher

Copy link
Contributor

github-actions bot commented Oct 8, 2024

🐰 Bencher Report

Branch1194/merge
Testbedsv2

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
client_sv2_handle_message_common📈 view plot
⚠️ NO THRESHOLD
44.32
client_sv2_handle_message_mining📈 view plot
⚠️ NO THRESHOLD
74.97
client_sv2_mining_message_submit_standard📈 view plot
⚠️ NO THRESHOLD
14.75
client_sv2_mining_message_submit_standard_serialize📈 view plot
⚠️ NO THRESHOLD
266.91
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
⚠️ NO THRESHOLD
590.45
client_sv2_open_channel📈 view plot
⚠️ NO THRESHOLD
165.39
client_sv2_open_channel_serialize📈 view plot
⚠️ NO THRESHOLD
268.96
client_sv2_open_channel_serialize_deserialize📈 view plot
⚠️ NO THRESHOLD
379.62
client_sv2_setup_connection📈 view plot
⚠️ NO THRESHOLD
162.46
client_sv2_setup_connection_serialize📈 view plot
⚠️ NO THRESHOLD
473.84
client_sv2_setup_connection_serialize_deserialize📈 view plot
⚠️ NO THRESHOLD
991.42
🐰 View full continuous benchmarking report in Bencher

Copy link
Contributor

github-actions bot commented Oct 8, 2024

🐰 Bencher Report

Branch1194/merge
Testbedsv1

⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkEstimated Cyclesestimated cyclesInstructionsinstructionsL1 AccessesaccessesL2 AccessesaccessesRAM Accessesaccesses
get_authorize📈 view plot
⚠️ NO THRESHOLD
8,553.00📈 view plot
⚠️ NO THRESHOLD
3,772.00📈 view plot
⚠️ NO THRESHOLD
5,293.00📈 view plot
⚠️ NO THRESHOLD
8.00📈 view plot
⚠️ NO THRESHOLD
92.00
get_submit📈 view plot
⚠️ NO THRESHOLD
95,438.00📈 view plot
⚠️ NO THRESHOLD
59,522.00📈 view plot
⚠️ NO THRESHOLD
85,508.00📈 view plot
⚠️ NO THRESHOLD
47.00📈 view plot
⚠️ NO THRESHOLD
277.00
get_subscribe📈 view plot
⚠️ NO THRESHOLD
8,076.00📈 view plot
⚠️ NO THRESHOLD
2,848.00📈 view plot
⚠️ NO THRESHOLD
3,981.00📈 view plot
⚠️ NO THRESHOLD
14.00📈 view plot
⚠️ NO THRESHOLD
115.00
serialize_authorize📈 view plot
⚠️ NO THRESHOLD
12,332.00📈 view plot
⚠️ NO THRESHOLD
5,343.00📈 view plot
⚠️ NO THRESHOLD
7,457.00📈 view plot
⚠️ NO THRESHOLD
9.00📈 view plot
⚠️ NO THRESHOLD
138.00
serialize_deserialize_authorize📈 view plot
⚠️ NO THRESHOLD
24,863.00📈 view plot
⚠️ NO THRESHOLD
9,920.00📈 view plot
⚠️ NO THRESHOLD
14,018.00📈 view plot
⚠️ NO THRESHOLD
34.00📈 view plot
⚠️ NO THRESHOLD
305.00
serialize_deserialize_handle_authorize📈 view plot
⚠️ NO THRESHOLD
30,371.00📈 view plot
⚠️ NO THRESHOLD
12,097.00📈 view plot
⚠️ NO THRESHOLD
17,141.00📈 view plot
⚠️ NO THRESHOLD
56.00📈 view plot
⚠️ NO THRESHOLD
370.00
serialize_deserialize_handle_submit📈 view plot
⚠️ NO THRESHOLD
126,441.00📈 view plot
⚠️ NO THRESHOLD
73,363.00📈 view plot
⚠️ NO THRESHOLD
105,196.00📈 view plot
⚠️ NO THRESHOLD
112.00📈 view plot
⚠️ NO THRESHOLD
591.00
serialize_deserialize_handle_subscribe📈 view plot
⚠️ NO THRESHOLD
27,911.00📈 view plot
⚠️ NO THRESHOLD
9,666.00📈 view plot
⚠️ NO THRESHOLD
13,681.00📈 view plot
⚠️ NO THRESHOLD
60.00📈 view plot
⚠️ NO THRESHOLD
398.00
serialize_deserialize_submit📈 view plot
⚠️ NO THRESHOLD
115,415.00📈 view plot
⚠️ NO THRESHOLD
68,223.00📈 view plot
⚠️ NO THRESHOLD
97,935.00📈 view plot
⚠️ NO THRESHOLD
66.00📈 view plot
⚠️ NO THRESHOLD
490.00
serialize_deserialize_subscribe📈 view plot
⚠️ NO THRESHOLD
23,397.00📈 view plot
⚠️ NO THRESHOLD
8,225.00📈 view plot
⚠️ NO THRESHOLD
11,592.00📈 view plot
⚠️ NO THRESHOLD
37.00📈 view plot
⚠️ NO THRESHOLD
332.00
serialize_submit📈 view plot
⚠️ NO THRESHOLD
99,831.00📈 view plot
⚠️ NO THRESHOLD
61,566.00📈 view plot
⚠️ NO THRESHOLD
88,351.00📈 view plot
⚠️ NO THRESHOLD
49.00📈 view plot
⚠️ NO THRESHOLD
321.00
serialize_subscribe📈 view plot
⚠️ NO THRESHOLD
11,405.00📈 view plot
⚠️ NO THRESHOLD
4,195.00📈 view plot
⚠️ NO THRESHOLD
5,840.00📈 view plot
⚠️ NO THRESHOLD
14.00📈 view plot
⚠️ NO THRESHOLD
157.00
🐰 View full continuous benchmarking report in Bencher

Copy link
Contributor

github-actions bot commented Oct 8, 2024

🐰 Bencher Report

Branch1194/merge
Testbedsv2

⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkEstimated Cyclesestimated cyclesInstructionsinstructionsL1 AccessesaccessesL2 AccessesaccessesRAM Accessesaccesses
client_sv2_handle_message_common📈 view plot
⚠️ NO THRESHOLD
2,057.00📈 view plot
⚠️ NO THRESHOLD
465.00📈 view plot
⚠️ NO THRESHOLD
722.00📈 view plot
⚠️ NO THRESHOLD
8.00📈 view plot
⚠️ NO THRESHOLD
37.00
client_sv2_handle_message_mining📈 view plot
⚠️ NO THRESHOLD
8,204.00📈 view plot
⚠️ NO THRESHOLD
2,137.00📈 view plot
⚠️ NO THRESHOLD
3,159.00📈 view plot
⚠️ NO THRESHOLD
36.00📈 view plot
⚠️ NO THRESHOLD
139.00
client_sv2_mining_message_submit_standard📈 view plot
⚠️ NO THRESHOLD
6,251.00📈 view plot
⚠️ NO THRESHOLD
1,742.00📈 view plot
⚠️ NO THRESHOLD
2,536.00📈 view plot
⚠️ NO THRESHOLD
22.00📈 view plot
⚠️ NO THRESHOLD
103.00
client_sv2_mining_message_submit_standard_serialize📈 view plot
⚠️ NO THRESHOLD
14,580.00📈 view plot
⚠️ NO THRESHOLD
4,686.00📈 view plot
⚠️ NO THRESHOLD
6,745.00📈 view plot
⚠️ NO THRESHOLD
48.00📈 view plot
⚠️ NO THRESHOLD
217.00
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
⚠️ NO THRESHOLD
27,404.00📈 view plot
⚠️ NO THRESHOLD
10,577.00📈 view plot
⚠️ NO THRESHOLD
15,389.00📈 view plot
⚠️ NO THRESHOLD
86.00📈 view plot
⚠️ NO THRESHOLD
331.00
client_sv2_open_channel📈 view plot
⚠️ NO THRESHOLD
4,295.00📈 view plot
⚠️ NO THRESHOLD
1,453.00📈 view plot
⚠️ NO THRESHOLD
2,150.00📈 view plot
⚠️ NO THRESHOLD
9.00📈 view plot
⚠️ NO THRESHOLD
60.00
client_sv2_open_channel_serialize📈 view plot
⚠️ NO THRESHOLD
13,868.00📈 view plot
⚠️ NO THRESHOLD
5,056.00📈 view plot
⚠️ NO THRESHOLD
7,318.00📈 view plot
⚠️ NO THRESHOLD
36.00📈 view plot
⚠️ NO THRESHOLD
182.00
client_sv2_open_channel_serialize_deserialize📈 view plot
⚠️ NO THRESHOLD
22,593.00📈 view plot
⚠️ NO THRESHOLD
8,019.00📈 view plot
⚠️ NO THRESHOLD
11,663.00📈 view plot
⚠️ NO THRESHOLD
79.00📈 view plot
⚠️ NO THRESHOLD
301.00
client_sv2_setup_connection📈 view plot
⚠️ NO THRESHOLD
4,631.00📈 view plot
⚠️ NO THRESHOLD
1,494.00📈 view plot
⚠️ NO THRESHOLD
2,266.00📈 view plot
⚠️ NO THRESHOLD
11.00📈 view plot
⚠️ NO THRESHOLD
66.00
client_sv2_setup_connection_serialize📈 view plot
⚠️ NO THRESHOLD
16,060.00📈 view plot
⚠️ NO THRESHOLD
5,955.00📈 view plot
⚠️ NO THRESHOLD
8,655.00📈 view plot
⚠️ NO THRESHOLD
39.00📈 view plot
⚠️ NO THRESHOLD
206.00
client_sv2_setup_connection_serialize_deserialize📈 view plot
⚠️ NO THRESHOLD
35,400.00📈 view plot
⚠️ NO THRESHOLD
14,847.00📈 view plot
⚠️ NO THRESHOLD
21,815.00📈 view plot
⚠️ NO THRESHOLD
92.00📈 view plot
⚠️ NO THRESHOLD
375.00
🐰 View full continuous benchmarking report in Bencher

@plebhash
Copy link
Collaborator Author

plebhash commented Oct 8, 2024

closed in favor of #1193

@plebhash plebhash deleted the fix_workspace_warnings branch October 8, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo warnings for unused manifest keys
1 participant