add package to support metadata #1193
Open
+200
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencher Report
|
| Branch | 1193/merge |
| Testbed | sv1 |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| client-submit-serialize | 📈 view plot | 6,774.30 |
| client-submit-serialize-deserialize | 📈 view plot | 7,793.40 |
| client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | 📈 view plot | 8,351.40 |
| client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | 📈 view plot | 914.46 |
| client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | 📈 view plot | 720.77 |
| client-sv1-authorize-serialize/client-sv1-authorize-serialize | 📈 view plot | 247.60 |
| client-sv1-get-authorize/client-sv1-get-authorize | 📈 view plot | 158.12 |
| client-sv1-get-submit | 📈 view plot | 6,585.90 |
| client-sv1-get-subscribe/client-sv1-get-subscribe | 📈 view plot | 275.24 |
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | 📈 view plot | 770.28 |
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | 📈 view plot | 630.95 |
| client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | 📈 view plot | 205.54 |
|
| Branch | 1193/merge |
| Testbed | sv1 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | 📈 view plot | 8,587.00 | 📈 view plot | 3,772.00 | 📈 view plot | 5,292.00 | 📈 view plot | 8.00 | 📈 view plot | 93.00 |
| get_submit | 📈 view plot | 95,464.00 | 📈 view plot | 59,522.00 | 📈 view plot | 85,509.00 | 📈 view plot | 45.00 | 📈 view plot | 278.00 |
| get_subscribe | 📈 view plot | 8,102.00 | 📈 view plot | 2,848.00 | 📈 view plot | 3,982.00 | 📈 view plot | 12.00 | 📈 view plot | 116.00 |
| serialize_authorize | 📈 view plot | 12,366.00 | 📈 view plot | 5,343.00 | 📈 view plot | 7,456.00 | 📈 view plot | 9.00 | 📈 view plot | 139.00 |
| serialize_deserialize_authorize | 📈 view plot | 24,889.00 | 📈 view plot | 9,920.00 | 📈 view plot | 14,019.00 | 📈 view plot | 32.00 | 📈 view plot | 306.00 |
| serialize_deserialize_handle_authorize | 📈 view plot | 30,431.00 | 📈 view plot | 12,097.00 | 📈 view plot | 17,141.00 | 📈 view plot | 54.00 | 📈 view plot | 372.00 |
| serialize_deserialize_handle_submit | 📈 view plot | 126,467.00 | 📈 view plot | 73,363.00 | 📈 view plot | 105,197.00 | 📈 view plot | 110.00 | 📈 view plot | 592.00 |
| serialize_deserialize_handle_subscribe | 📈 view plot | 27,987.00 | 📈 view plot | 9,666.00 | 📈 view plot | 13,677.00 | 📈 view plot | 62.00 | 📈 view plot | 400.00 |
| serialize_deserialize_submit | 📈 view plot | 115,403.00 | 📈 view plot | 68,223.00 | 📈 view plot | 97,938.00 | 📈 view plot | 63.00 | 📈 view plot | 490.00 |
| serialize_deserialize_subscribe | 📈 view plot | 23,423.00 | 📈 view plot | 8,225.00 | 📈 view plot | 11,593.00 | 📈 view plot | 35.00 | 📈 view plot | 333.00 |
| serialize_submit | 📈 view plot | 99,857.00 | 📈 view plot | 61,566.00 | 📈 view plot | 88,352.00 | 📈 view plot | 47.00 | 📈 view plot | 322.00 |
| serialize_subscribe | 📈 view plot | 11,431.00 | 📈 view plot | 4,195.00 | 📈 view plot | 5,841.00 | 📈 view plot | 12.00 | 📈 view plot | 158.00 |
|
| Branch | 1193/merge |
| Testbed | sv2 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot | 2,171.00 | 📈 view plot | 473.00 | 📈 view plot | 731.00 | 📈 view plot | 8.00 | 📈 view plot | 40.00 |
| client_sv2_handle_message_mining | 📈 view plot | 8,216.00 | 📈 view plot | 2,137.00 | 📈 view plot | 3,156.00 | 📈 view plot | 39.00 | 📈 view plot | 139.00 |
| client_sv2_mining_message_submit_standard | 📈 view plot | 6,353.00 | 📈 view plot | 1,750.00 | 📈 view plot | 2,548.00 | 📈 view plot | 19.00 | 📈 view plot | 106.00 |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot | 14,716.00 | 📈 view plot | 4,694.00 | 📈 view plot | 6,756.00 | 📈 view plot | 45.00 | 📈 view plot | 221.00 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot | 27,536.00 | 📈 view plot | 10,585.00 | 📈 view plot | 15,401.00 | 📈 view plot | 82.00 | 📈 view plot | 335.00 |
| client_sv2_open_channel | 📈 view plot | 4,401.00 | 📈 view plot | 1,461.00 | 📈 view plot | 2,161.00 | 📈 view plot | 7.00 | 📈 view plot | 63.00 |
| client_sv2_open_channel_serialize | 📈 view plot | 13,970.00 | 📈 view plot | 5,064.00 | 📈 view plot | 7,330.00 | 📈 view plot | 33.00 | 📈 view plot | 185.00 |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot | 22,729.00 | 📈 view plot | 8,027.00 | 📈 view plot | 11,674.00 | 📈 view plot | 76.00 | 📈 view plot | 305.00 |
| client_sv2_setup_connection | 📈 view plot | 4,741.00 | 📈 view plot | 1,502.00 | 📈 view plot | 2,276.00 | 📈 view plot | 10.00 | 📈 view plot | 69.00 |
| client_sv2_setup_connection_serialize | 📈 view plot | 16,162.00 | 📈 view plot | 5,963.00 | 📈 view plot | 8,667.00 | 📈 view plot | 36.00 | 📈 view plot | 209.00 |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot | 35,536.00 | 📈 view plot | 14,855.00 | 📈 view plot | 21,826.00 | 📈 view plot | 89.00 | 📈 view plot | 379.00 |
|
hmm I'm not sure we want to have empty files to just to suppress warnings, that feels like the opposite direction see #1194 |
@plebhash, I’m unsure about removing the metadata from the root Cargo file. Another possible way to retain the metadata is by adding it to each crate within the workspace, but that seems excessive. I’m fine with either approach. |
|
I didn't notice you were assigned to #1192 feel free to modify this PR instead of #1194 but yeah, we can "transfer" the relevant fields from the workspace the main point is that those fields need to be removed from the workspace and we should not suppress the warnings by creating empty packages, that definitely feels like the wrong direction |
Closed
Shourya742
force-pushed
the
2024-10-remove-manifest-warning
branch
from
883eadb
to
0cbc1dd
Compare
jbesraa
suggested changes
Oct 9, 2024
There was a problem hiding this comment.
Few nits:
- What do you think about adding
descriptionas well? documentationis always linking to "https://github.com/stratum-mining/stratum", why not link to the specific crate docs on docs.rs?
| @@ -1,7 +1,7 @@ | |||
| [package] | |||
| name = "interop-cpp" | |||
| version = "0.1.0" | |||
| authors = ["fi3 <email@email.org>"] | |||
| description = "API for bridging SV1 miners to SV2 pools" | ||
| license = "MIT OR Apache-2.0" | ||
| documentation = "https://github.com/stratum-mining/stratum" | ||
| license = "MIT + Apache-2.0" |
There was a problem hiding this comment.
I didn't get it, Can you elaborate?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1192