Deny unused self parameters in clippy

Makefile

@@ -129,7 +129,7 @@ CLIPPY_PEDANTIC = -D clippy::await_holding_lock \
                   -D clippy::unreadable_literal \
                   -D clippy::unsafe_derive_deserialize \
                   -A clippy::unseparated_literal_suffix \
-                  -A clippy::unused_self \
+                  -D clippy::unused_self \
                   -D clippy::used_underscore_binding \
                   -D clippy::used_underscore_binding \
                   -D clippy::verbose_bit_mask \

src/engine/sim_engine/pool.rs

@@ -78,6 +78,7 @@ impl SimPool {
         self.encryption_info().is_encrypted()
     }
 
+    #[allow(clippy::unused_self)]
     pub fn destroy(&mut self) -> StratisResult<()> {
         Ok(())
     }

src/engine/strat_engine/backstore/crypt/initialize.rs

@@ -127,7 +127,6 @@ impl CryptInitializer {
 
     /// Initialize with a passphrase in the kernel keyring only.
     fn initialize_with_keyring(
-        &self,
         device: &mut CryptDevice,
         key_description: &KeyDescription,
     ) -> StratisResult<()> {
@@ -187,7 +186,7 @@ impl CryptInitializer {
         key_description: &KeyDescription,
         (pin, json, yes): (&str, &Value, bool),
     ) -> StratisResult<()> {
-        self.initialize_with_keyring(&mut device, key_description)?;
+        Self::initialize_with_keyring(&mut device, key_description)?;
 
         let fs = MemoryPrivateFilesystem::new()?;
         fs.key_op(key_description, |kf| {
@@ -228,7 +227,7 @@ impl CryptInitializer {
                 self.acquire_crypt_device()?
             }
             (Some(kd), _) => {
-                self.initialize_with_keyring(&mut device, kd)?;
+                Self::initialize_with_keyring(&mut device, kd)?;
                 device
             }
             (_, Some(ci)) => {

src/engine/strat_engine/keys.rs

@@ -388,7 +388,6 @@ impl StratKeyActions {
     /// of the key. This method is only useful for testing stratisd internally. It
     /// is not useful for testing using D-Bus.
     pub fn set_no_fd(
-        &mut self,
         key_desc: &KeyDescription,
         key: SizedKeyMemory,
     ) -> StratisResult<MappingCreateAction<Key>> {

src/engine/strat_engine/tests/crypt.rs

@@ -36,7 +36,7 @@ where
         .unwrap();
     let key_data = SizedKeyMemory::new(mem, MAX_STRATIS_PASS_SIZE);
 
-    key_handle.set_no_fd(&key_description, key_data)?;
+    StratKeyActions::set_no_fd(&key_description, key_data)?;
 
     let result = test(physical_paths, &key_description, input);
 

src/engine/strat_engine/thinpool/filesystem.rs

@@ -234,7 +234,7 @@ impl StratFilesystem {
                     if free_bytes.sectors() < FILESYSTEM_LOWATER {
                         let mut table = self.thin_dev.table().table.clone();
                         table.length =
-                            self.thin_dev.size() + self.extend_size(self.thin_dev.size());
+                            self.thin_dev.size() + Self::extend_size(self.thin_dev.size());
                         if self.thin_dev.set_table(get_dm(), table).is_err() {
                             return Ok(false);
                         }
@@ -260,7 +260,7 @@ impl StratFilesystem {
     /// Return an extend size for the thindev under the filesystem
     /// TODO: returning the current size will double the space provisioned to
     /// the thin device.  We should determine if this is a reasonable value.
-    fn extend_size(&self, current_size: Sectors) -> Sectors {
+    fn extend_size(current_size: Sectors) -> Sectors {
         current_size
     }