Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deny unused self parameters in clippy #2587

Merged
merged 2 commits into from
May 11, 2021
Merged

Deny unused self parameters in clippy #2587

merged 2 commits into from
May 11, 2021

Conversation

jbaublitz
Copy link
Member

Closes #2225

@jbaublitz jbaublitz requested a review from mulkieran May 11, 2021 17:31
@jbaublitz jbaublitz self-assigned this May 11, 2021
@mulkieran
Copy link
Member

@jbaublitz I'm fine if you want to fix these lints as part of the upcoming release.

@jbaublitz
Copy link
Member Author

@mulkieran Whoops! None of these failures showed up on my local machine. I'm not entire sure why that is.

@jbaublitz
Copy link
Member Author

Ah, it was stale state in my target directory.

@mulkieran mulkieran merged commit 3dd85ac into stratis-storage:develop-2.4.0 May 11, 2021
@jbaublitz jbaublitz deleted the issue-stratisd-2225 branch July 22, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mulkieran mulkieran mulkieran approved these changes

Assignees

@jbaublitz jbaublitz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate clippy lint unused_self
2 participants
@jbaublitz @mulkieran