Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #9383 from baker-travis/knob-groups-overflow-not-scrolling #9383

Merged

Conversation

baker-travis
Copy link

fixes #9299

Issue:

What I did

Allowed the overflow of the container holding the knob categories.

How to test

  1. Use the official-storybook example project
  2. Navigate to Addons -> Knobs -> withKnobs -> tweaks static values organized in groups.
  3. Move the panel that contains "Knobs" to the right side of your screen.
  4. Observe that you can now scroll the knob categories.
  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented Jan 10, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/g6gideupr
✅ Preview: https://monorepo-git-fork-baker-travis-knob-groups-overflo-ee772d.storybook.now.sh

@ndelangen
Copy link
Member

Thank you @baker-travis !

@ndelangen
Copy link
Member

@baker-travis would you be able to resolve the merge conflicts? Would love to merge this in.

@baker-travis
Copy link
Author

@ndelangen Updated the branch, should be good to go now.

@ndelangen
Copy link
Member

Thanks!

@ndelangen ndelangen changed the base branch from next-6.0.0 to next January 28, 2020 01:13
@ndelangen ndelangen self-assigned this Jan 28, 2020
@shilman shilman changed the title fix: allow tabs to scroll horizontally UI: Fix tabs to scroll horizontally Jan 29, 2020
@shilman shilman changed the title UI: Fix tabs to scroll horizontally Merge pull request #9383 from baker-travis/knob-groups-overflow-not-scrolling Jan 29, 2020
@shilman shilman merged commit 17095f8 into storybookjs:next Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addon-knobs tab groups do not support horizontal scrolling on the panel
3 participants