Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addon-knobs tab groups do not support horizontal scrolling on the panel #9299

Closed
christiancooksponge opened this issue Jan 2, 2020 · 3 comments · Fixed by #9383
Closed

Comments

@christiancooksponge
Copy link
Contributor

Describe the bug
When there are too many groups for the knobs addon, the tabs flow off the edge of the container. The user is then unable to scroll horizontally to see the hidden tab groups.

To Reproduce
Steps to reproduce the behavior:

  1. Create multiple tab groups for knobs so it exceeds the panel width
  2. Try and horizontally scroll the tabs

Expected behavior
Horizontal scrolling behaviour should be present on the group tabs, much like the tabs for the addons bar above.

Screenshots
image

In this screenshot, the addon tabs scroll correctly when there are more addons added, however the tabs for the knobs addon below do not scroll.

@baker-travis
Copy link

I took a stab at fixing this one in the PR above. Just added a line of css to allow overflow on the container.

baker-travis pushed a commit to baker-travis/storybook that referenced this issue Jan 24, 2020
@shilman
Copy link
Member

shilman commented Jan 30, 2020

Yo-ho-ho!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-alpha.2 containing PR #9383 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

@christiancooksponge
Copy link
Contributor Author

@baker-travis @shilman thank you both for your contributions to getting this issue resolved... I will upgrade and give it a whirl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants