Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint error from #6923 #7311

Merged
merged 3 commits into from
Jul 4, 2019
Merged

Conversation

lonyele
Copy link
Member

@lonyele lonyele commented Jul 4, 2019

Issue: #7313

Context

#7190 had a file conflict after #6923 was merged because of the change of addon-events file

I git pull upstream next and push git push origin feature/migrate-addon-events and I get the lint failed

I'm not sure but all the PRs pushed after #6923 will get this same lint fails?(yes)
#7307 CI fails
#7308 CI fails

What I did

I fixed the this one lint error import/no-named-as-default-member

@vercel
Copy link

vercel bot commented Jul 4, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-lonyele-fix-lint-errors.storybook.now.sh

@vercel vercel bot temporarily deployed to staging July 4, 2019 15:02 Inactive
@ndelangen ndelangen merged commit 9062e93 into storybookjs:next Jul 4, 2019
@lonyele
Copy link
Member Author

lonyele commented Jul 4, 2019

@ndelangen Thanks for the more refined fix

@ndelangen
Copy link
Member

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants