Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting fails after upgrading to the latest commit #7313

Closed
lonyele opened this issue Jul 4, 2019 · 1 comment
Closed

Linting fails after upgrading to the latest commit #7313

lonyele opened this issue Jul 4, 2019 · 1 comment
Labels

Comments

@lonyele
Copy link
Member

lonyele commented Jul 4, 2019

Describe the bug
yarn lint fails after #6923 is merged

To Reproduce
Steps to reproduce the behavior:

  1. git clone or git pull to the latest next branch after Addons: Disable option for addon tab #6923 is merged
  2. Setting up project and run yarn lint
  3. See errors
/tmp/storybook/addons/ondevice-backgrounds/src/BackgroundPanel.js
  66:42  error  Caution: `Constants` also has a named export `PARAM_KEY`. Check if you meant to write `import {PARAM_KEY} from './constants'` instead  import/no-named-as-default-member

Expected behavior
yarn lint result should be success

Screenshots
#7190 CI fails

#7307 CI fails

#7308 CI fails

@lonyele lonyele added the bug label Jul 4, 2019
@lonyele lonyele changed the title Linting fails after upgrading to the latest commit(#6923) Linting fails after upgrading to the latest commit Jul 4, 2019
@lonyele lonyele closed this as completed Jul 4, 2019
@shilman
Copy link
Member

shilman commented Jul 5, 2019

Ermahgerd!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-alpha.36 containing PR #7311 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants