-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React: Bundle in lodash
#28609
React: Bundle in lodash
#28609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Moved 'lodash' from 'dependencies' to 'devDependencies' in
code/renderers/vue3/package.json
- Ensures 'lodash' is only used during development
- Potentially reduces final production bundle size
- Aims to resolve issue mentioned in linked comment
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
lodash
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 55f141a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
I just looked at how often we are using Let's do this to fix it temporarily, but let's figure out a smaller replacement for lodash in the near future. I guess we want to prebundle
@ndelangen WDYT? |
@ndelangen Should we use https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore?tab=readme-ov-file#eslint-plugin to replace unnecessary usages of lodash and potentially get entirely rid of it? |
In this PR I do both renderers, cause that seemed to make sense. I'm considering blocks and addon-controls as well.. The other packages are only run in node AFAIK, and always in CJS, so those don't have to be changed?
Yes, that's a valid concern! Though it should be able to tree-shake to only the parts of I'm definitely interested in removing all references to |
What I did
Hopefully this fixes the problem discribed in this comment:
#28607 (comment)
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-28609-sha-1103d7ff
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-28609-sha-1103d7ff sandbox
or in an existing project withnpx storybook@0.0.0-pr-28609-sha-1103d7ff upgrade
.More information
0.0.0-pr-28609-sha-1103d7ff
norbert/bundle-in-lodash
1103d7ff
1721057420
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=28609