-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Re-Add Nuxt support #28607
base: next
Are you sure you want to change the base?
CLI: Re-Add Nuxt support #28607
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 846bf4b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
@tobiasdiez
|
@tobiasdiez npx nuxi@latest init (pnpm)
@ndelangen This might be CPC related, though. |
Thanks for this PR and your tests!
I can reproduce it as well. The problem is that in our setup Simplest solution: just add More involved solution: make it possible that presets return a javascript object as builder, instead of only a module name. (Similar to how eslint v9 is handling plugins now). Do you have any preference, or another idea? |
I've fixed this already in the main branch by adding lodash to optimizeDeps: |
@tobiasdiez Take a look at https://github.com/storybookjs/storybook/blob/next/code/frameworks/angular/src/preset.ts#L31. You can see that you can also just pass an absolute path as a value. With this approach, you make sure that |
Many thanks. This worked like a charm! 🚀 In nuxt-modules/storybook#729, I've now also added e2e tests (using this PR here to add storybook to a nuxt starter). Running |
@valentinpalkovic @tobiasdiez Maybe it is best if we have Nuxt sandbox over here:
|
@tobiasdiez As Kasper mentioned, we could add Nuxt to our sandboxes, and you could test the sandbox on this PR and rerun it every time you release a new Canary version. Otherwise, I don't see an easy way to copy over our test suite setup to your repository. |
Hello @tobiasdiez do you have any news when this draft will be merged ? |
@kasperpeulen @valentinpalkovic Thanks for the suggestion. Adding a sandbox would indeed give some confidence that things are working, but I was hoping for a solution that we can apply in downstream projects (e.g. that PRs to the nuxt storybook addon are not breaking things). Similar to https://www.npmjs.com/package/@apollo/server-integration-testsuite. @KeremTurkyilmaz We first need to fix the major bugs in the nuxt module. Help moving this forward is of course very welcome! |
@tobiasdiez Unfortunately, we don't have a dedicated testsuite solution like Apollo does. :/ |
I've added a nuxt sandbox, but not sure if I did it correctly (it appears it is not run as part of the ci) |
What I did
Reverts #28479
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-28607-sha-b9bf7d39
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-28607-sha-b9bf7d39 sandbox
or in an existing project withnpx storybook@0.0.0-pr-28607-sha-b9bf7d39 upgrade
.More information
0.0.0-pr-28607-sha-b9bf7d39
revert-28479-revert/26884
b9bf7d39
1721048903
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=28607