Addon-knobs: : add number config options

[lifeiscontent]

Fix inconsistency in number API

fix step,min,max attributes in number type

Issue:

What I did

Fixed inconsistency in number type.

How to test

when setting the options of a number, the step,min,max attributes now get applied.

Is this testable with jest or storyshots? Yes, but I didn't write a test.

Does this need a new example in the kitchen sink apps? No.

Does this need an update to the documentation? Not really, but I could add an example.

If your answer is yes to any of these, please make sure to include it in your PR.

[codecov]

Codecov Report

Merging #2371 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2371      +/-   ##
==========================================
- Coverage   19.92%   19.92%   -0.01%     
==========================================
  Files         293      293              
  Lines        6484     6485       +1     
  Branches      752      755       +3     
==========================================
  Hits         1292     1292              
- Misses       4597     4607      +10     
+ Partials      595      586       -9

Impacted Files	Coverage Δ
addons/knobs/src/components/types/Number.js	7.93% <0%> (-0.13%)	⬇️
addons/knobs/src/components/types/Color.js	8.21% <0%> (ø)	⬆️
...es__/update-addon-info/update-addon-info.output.js	0% <0%> (ø)	⬆️
addons/events/src/components/Event.js	0% <0%> (ø)	⬆️
addons/a11y/src/components/Report/Rules.js	0% <0%> (ø)	⬆️
lib/ui/src/libs/key_events.js	23.25% <0%> (ø)	⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js	6.25% <0%> (ø)	⬆️
...rc/modules/ui/components/left_panel/text_filter.js	30.98% <0%> (ø)	⬆️
addons/jest/src/components/Indicator.js	0% <0%> (ø)	⬆️
addons/a11y/src/A11yManager.js	0% <0%> (ø)	⬆️
... and 27 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 553bccd...652f862. Read the comment docs.

[Hypnosphi]

That's great, thanks! This fixes #1632

Does this need a new example in the kitchen sink apps

Actually, I think it does. Please add one here: https://github.com/storybooks/storybook/blob/master/examples/cra-kitchen-sink/src/stories/addon-knobs.stories.js

You may need to run yarn jest -u to update storyshots after that

[ndelangen]

Thank you for this PR @lifeiscontent !

@Hypnosphi Looks like the min,max,step was already in the example?
https://github.com/storybooks/storybook/blob/master/examples/cra-kitchen-sink/src/stories/addon-knobs.stories.js#L52

[Hypnosphi]

@ndelangen we need the same but without range: true

[lifeiscontent]

@Hypnosphi how do I run the kitchen sink example?

I tried the following.

yarn
yarn bootstrap # and selected core and examples
cd storybook/examples/cra-kitchen-sink
yarn storybook

but I get issues saying none of the storybook modules exist.

[lifeiscontent]

@Hypnosphi updated!

[Hypnosphi]

This example includes a lot of other knobs, not only the range input

[Hypnosphi]

Let’s add min/max/step to dollars below instead of duplicating the example

[Hypnosphi]

Please run yarn jest -u after that

[Hypnosphi]

Let’s add min/max/step to dollars below instead of duplicating the example

[lifeiscontent]

@Hypnosphi updated.

I ran jest, but it seems there are tests failing that are unrelated.

[Hypnosphi]

Ok looks like it passes as is. I'll be to test the example manually in a few hours