Merge pull request #2371 from lifeiscontent/patch-1

Update Number.js
storybookjs · Nov 26, 2017 · ce69ca8 · ce69ca8
2 parents 553bccd + 652f862
commit ce69ca8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/addons/knobs/src/components/types/Number.js b/addons/knobs/src/components/types/Number.js
@@ -34,6 +34,9 @@ class NumberType extends React.Component {
         style={styles}
         value={knob.value}
         type="number"
+        min={knob.min}
+        max={knob.max}
+        step={knob.step}
         onChange={() => onChange(parseFloat(this.input.value))}
       />
     );

diff --git a/examples/cra-kitchen-sink/src/stories/addon-knobs.stories.js b/examples/cra-kitchen-sink/src/stories/addon-knobs.stories.js
@@ -56,7 +56,7 @@ storiesOf('Addon Knobs.withKnobs', module)
       cherry: 'Cherry',
     };
     const fruit = select('Fruit', fruits, 'apple');
-    const dollars = number('Dollars', 12.5);
+    const dollars = number('Dollars', 12.5, { min: 0, max: 100, step: 0.01 });
 
     const backgroundColor = color('background', '#ffff00');
     const items = array('Items', ['Laptop', 'Book', 'Whiskey']);
@@ -111,7 +111,7 @@ storiesOf('Addon Knobs.withKnobsOptions', module)
       cherry: 'Cherry',
     };
     const fruit = select('Fruit', fruits, 'apple');
-    const dollars = number('Dollars', 12.5);
+    const dollars = number('Dollars', 12.5, { min: 0, max: 100, step: 0.01 });
 
     const backgroundColor = color('background', '#ffff00');
     const items = array('Items', ['Laptop', 'Book', 'Whiskey']);